1232788 - Wrong SIM Pin warning screen shows a placeholder string of text

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Pi Wei Cheng [:piwei] (inactive)]

Attachment: screenshot of issue

Description:
If user enters wrong SIM pin on the Enter SIM Pin page, the page shows a string of red colored text 'pinErrorMsg'.

STR:
1) Attempt to do anything that will require entering of SIM Pin, such as turn on or off SIM Pin in Settings
2) Enter wrong SIM Pin and observe the retry dialog

Expected: Everything is in proper English

Actual: There's a string of red text that says 'pinErrorMsg'. See screenshot.

This is observed on:
Device: Aries 2.6
BuildID: 20151215145647
Gaia: ee43a95f2bbe39c5ac8c9fcdec76749a56c02f2e
Gecko: cb66ffeb6725e8344818e8e2f707ae2eaeb953b4
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 46.0a1 (2.6) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:46.0) Gecko/46.0 Firefox/46.0

Device: Flame 2.6
BuildID: 20151215030209
Gaia: ad15b4f1f50f4e28170a069f049e5bdeec8d15cc
Gecko: ae37fdb042c07c0cb9d0afcd41372a96454f4f4f
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 46.0a1 (2.6) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:46.0) Gecko/46.0 Firefox/46.0

Comment 1

[Pi Wei Cheng [:piwei] (inactive)]

Attachment: logcat of issue

Comment 2

[Pi Wei Cheng [:piwei] (inactive)]

This issue is not affecting Flame 2.5. That red text is simply not present in 2.5.

Device: Flame 2.5
BuildID: 20151215162548
Gaia: 062e0fa48c1b5d5156f6911a5a4519128fac3231
Gecko: 7fffe3f2990dad2297ca474296933f85b2a573ab
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 44.0a2 (2.5) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Comment 3

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Let's get a window here but I think it's most likely the same root cause as the bug 1232448.

Comment 4

[Max Murrell [MMurrell]]

This issue appears to be caused by changes from Bug 1229221

B2G Inbound Regression Window

Last Working
Environmental Variables:
Device: Flame 2.6
BuildID: 20151209144041
Gaia: 7e962276913bd4da7ce5fa7540767107ce322c78
Gecko: 7525d39ca59104705e133f51cbd4cf5b1cdfc799
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 45.0a1 (2.6) 
Firmware Version: v18D

First Broken
Environmental Variables:
Device: Flame 2.6
BuildID: 20151209210551
Gaia: 6f60c55c63a8c3578e654fc23cd09372a5c25e52
Gecko: 8d3dff573dce06ee376ee4d231dc82a7cbe87e2d
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 45.0a1 (2.6) 
Firmware Version: v18D

Last Working gaia / First Broken gecko - Issue does not occur
Gaia: 7e962276913bd4da7ce5fa7540767107ce322c78
Gecko: 8d3dff573dce06ee376ee4d231dc82a7cbe87e2d

First Broken gaia / Last Working gecko - Issue does occur
Gaia: 6f60c55c63a8c3578e654fc23cd09372a5c25e52
Gecko: 7525d39ca59104705e133f51cbd4cf5b1cdfc799

Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/7e962276913bd4da7ce5fa7540767107ce322c78...6f60c55c63a8c3578e654fc23cd09372a5c25e52

Comment 5

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Zibi can you please take a look at this one as well?

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] zbraniecki:1232788-fix-pin-error-msg > mozilla-b2g:master

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8699542 [details] [review]
[gaia] zbraniecki:1232788-fix-pin-error-msg > mozilla-b2g:master

Similar story to bug 1232448. We sometimes used 'pinErrorMsg' although we changed it to 'newPinErrorMsg'. In two places the string has been updated, but here it was composited to old l10nId.

I do not have a sim card to test it now. Max, can you test with this patch if the bug is fixed?

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

Oh. I think I was wrong. 

We should not "newPinErrorMsg" - that string is used for when new and old pin don't match.

What's going on here is that we have the screen for when you entered wrong pin/puk/fdn and this screen has the following two strings:

fdnErrorMsg=The PIN2 code is incorrect.
pukErrorMsg=The PUK code is incorrect.

but the corresponding string:

pinErrorMsg=The PIN was incorrect.

has been removed in bug 840915 on September 3, 2013. Since then the code asks for 'pinErrorMsg' to be displayed but we don't have this string.

The solution I believe is to revert that change and bring back the string that corresponds to fdn/puk strings.

I updated the PR.

Comment 9

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Setting qawanted to get this checked for you Zibi.

Comment 10

[Pi Wei Cheng [:piwei] (inactive)]

The patch fixed the issue. The red text now says 'The PIN was incorrect' instead of that non English string. Tested on Aries and Flame.

Comment 11

[[e-mail]]

Comment on attachment 8699542 [details] [review]
[gaia] zbraniecki:1232788-fix-pin-error-msg > mozilla-b2g:master

good catch, thanks!

Comment 12

[Zibi Braniecki [:zbraniecki][:gandalf]]

Commit: https://github.com/mozilla-b2g/gaia/commit/8857de6b0f622d22fbe1407b1e2e1658e41f7c84

Comment 13

[Lance（leave from Mozilla）]

Attachment: Verified video: Flame KK master.3GP

This bug has been verified as "Pass" on the latest build of Flame KK master (512mb) and Aries KK master by the STR in comment 0.
Actual result: 
Everything is in proper English.
Occurrence rate: 0/10.

Device: Flame KK master 512mb (Pass)
Build ID               20151221150211
Gaia Revision          14aefb2519becfa32f31bcc3c9c995693421f19c
Gaia Date              2015-12-21 06:34:35
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/8c9825377d0d8115e9fed64fd3700b1e54700dbe
Gecko Version          46.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151221.182728
Firmware Date          Mon Dec 21 18:27:42 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK master (Pass)
Build ID               20151221204910
Gaia Revision          14aefb2519becfa32f31bcc3c9c995693421f19c
Gaia Date              2015-12-21 06:34:35
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/8c9825377d0d8115e9fed64fd3700b1e54700dbe
Gecko Version          46.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151221.200242
Firmware Date          Mon Dec 21 20:02:51 UTC 2015
Bootloader             s1