1232810 - Confirmation prompt for deletion of bookmark folders

Status: NEW

(Firefox for iOS :: Home screen, defect)

Description

[Richard Newman [:rnewman]]

If a bookmark folder contains non-separator children, we should prompt the user before deleting it -- when we do so, we will recursively mark it and its children as deleted, so this is a consequential action.

Some ideas:

<tecgirl> rnewman: "You have Bookmarks in this folder. Are you sure you want to delete it?" [Cancel] [Delete]
<@rnewman> tecgirl: "This folder isn't empty. Are you sure you want to delete it and its contents?"
<@rnewman> (trying to convey that the contents will go, too)
<tecgirl> that's a little long for an alert.
<@rnewman> yeah :/
<tecgirl> try it, see how it fits. the messaging is better, though.


Let's mock this up in a couple of locales so we can land the strings ASAP.

Comment 1

[Robin Andersen [:tecgirl]]

Attachment: English, German, Dutch, Korean string examples. (Pardon the weak translation.)

With :rnewman's string, which I prefer.

Comment 2

[Richard Newman [:rnewman]]

Looks great! 

Comment 3

[Richard Newman [:rnewman]]

N.B., when we're implementing this, we should make sure that roots -- toolbar, menu, unsorted, mobile -- cannot be deleted, returning no edit actions when asked by the table view.

Comment 4

[Richard Newman [:rnewman]]

Strings landed.

Comment 5

[Richard Newman [:rnewman]]

Strings finally really landed: a1cf994