Closed Bug 1232836 Opened 4 years ago Closed 4 years ago

Intermittent pinning_the_web_test.js | Pinning the Web Unpin site from same url

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.6 S5 - 1/15

People

(Reporter: KWierso, Assigned: apastor)

Details

(Keywords: intermittent-failure, Whiteboard: [systemsfe])

Attachments

(1 file)

Whiteboard: [systemsfe]
I'm also seeing this failure with this test:

TEST-UNEXPECTED-FAIL | apps/homescreen/test/marionette/pinning_the_web_test.js | Homescreen - Pin the web Pinning a site from the browser context menu
Error: timeout exceeded!
    at Object.Client.waitForSync (node_modules/marionette-client/lib/marionette/client.js:760:16)
    at Object.Client.waitFor (node_modules/marionette-client/lib/marionette/client.js:726:60)
    at Object.MarionetteHelper.waitForElement (node_modules/marionette-helper/index.js:142:12)
    at Object.pinDialog (apps/system/test/marionette/lib/pinning_the_web.js:21:31)
    at Object.PinningTheWeb._clickPinContextMenu (apps/system/test/marionette/lib/pinning_the_web.js:119:43)
    at Object.openAndPinSite [as openAndPinSiteFromBrowser] (apps/system/test/marionette/lib/pinning_the_web.js:72:10)
    at Context.<anonymous> (apps/homescreen/test/marionette/pinning_the_web_test.js:54:13)
    at Test.MarionetteTest.run (node_modules/marionette-js-runner/lib/ui.js:25:31)
    at node_modules/marionette-js-runner/node_modules/promise/lib/core.js:33:15
    at flush (node_modules/marionette-js-runner/node_modules/promise/node_modules/asap/asap.js:27:13)
nm, comment 1 is from the homescreen version of this test, which is a different test from the original report. I'll file a new bug.
Here's the failure I'm actually seeing, especiall with the retry logic in bug 1222215 disabled. I'm going to disable this test for now.

TEST-UNEXPECTED-FAIL | apps/system/test/marionette/pinning_the_web_test.js | Pinning the Web Pin site
AssertionError: false == true
    at Context.<anonymous> (apps/system/test/marionette/pinning_the_web_test.js:60:5)
    at Test.MarionetteTest.run (node_modules/marionette-js-runner/lib/ui.js:25:31)
    at node_modules/marionette-js-runner/node_modules/promise/lib/core.js:33:15
    at flush (node_modules/marionette-js-runner/node_modules/promise/node_modules/asap/asap.js:27:13)
Assignee: nobody → apastor
Target Milestone: --- → 2.6 S5 - 1/15
Comment on attachment 8706277 [details] [review]
[gaia] albertopq:1232836-intermittent-pinning > mozilla-b2g:master

Finally, all green!
Attachment #8706277 - Flags: review?(mhenretty)
Comment on attachment 8706277 [details] [review]
[gaia] albertopq:1232836-intermittent-pinning > mozilla-b2g:master

I know we are still seeing this test intermittently, but I think these changes need to land. Let's do this, land the changes and if the test gets a lot of stars we will re-disable it until we fix bug 1175116.
Attachment #8706277 - Flags: review?(mhenretty) → review+
master: https://github.com/mozilla-b2g/gaia/commit/626d0bc59f3d079bfd09dd2c3c72e0ad9331717c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.