1232836 - Intermittent pinning_the_web_test.js | Pinning the Web Unpin site from same url

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://treeherder.mozilla.org/logviewer.html#?job_id=6204285&repo=fx-team

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

I'm also seeing this failure with this test:

TEST-UNEXPECTED-FAIL | apps/homescreen/test/marionette/pinning_the_web_test.js | Homescreen - Pin the web Pinning a site from the browser context menu
Error: timeout exceeded!
    at Object.Client.waitForSync (node_modules/marionette-client/lib/marionette/client.js:760:16)
    at Object.Client.waitFor (node_modules/marionette-client/lib/marionette/client.js:726:60)
    at Object.MarionetteHelper.waitForElement (node_modules/marionette-helper/index.js:142:12)
    at Object.pinDialog (apps/system/test/marionette/lib/pinning_the_web.js:21:31)
    at Object.PinningTheWeb._clickPinContextMenu (apps/system/test/marionette/lib/pinning_the_web.js:119:43)
    at Object.openAndPinSite [as openAndPinSiteFromBrowser] (apps/system/test/marionette/lib/pinning_the_web.js:72:10)
    at Context.<anonymous> (apps/homescreen/test/marionette/pinning_the_web_test.js:54:13)
    at Test.MarionetteTest.run (node_modules/marionette-js-runner/lib/ui.js:25:31)
    at node_modules/marionette-js-runner/node_modules/promise/lib/core.js:33:15
    at flush (node_modules/marionette-js-runner/node_modules/promise/node_modules/asap/asap.js:27:13)

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

nm, comment 1 is from the homescreen version of this test, which is a different test from the original report. I'll file a new bug.

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

Here's the failure I'm actually seeing, especiall with the retry logic in bug 1222215 disabled. I'm going to disable this test for now.

TEST-UNEXPECTED-FAIL | apps/system/test/marionette/pinning_the_web_test.js | Pinning the Web Pin site
AssertionError: false == true
    at Context.<anonymous> (apps/system/test/marionette/pinning_the_web_test.js:60:5)
    at Test.MarionetteTest.run (node_modules/marionette-js-runner/lib/ui.js:25:31)
    at node_modules/marionette-js-runner/node_modules/promise/lib/core.js:33:15
    at flush (node_modules/marionette-js-runner/node_modules/promise/node_modules/asap/asap.js:27:13)

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

disabled in master: https://github.com/mozilla-b2g/gaia/commit/1b2d02d8a0ca742579fb929bc63a9ac4c1b0cc42

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1232836-intermittent-pinning > mozilla-b2g:master

Comment 6

[Alberto Pastor [:albertopq]]

Comment on attachment 8706277 [details] [review]
[gaia] albertopq:1232836-intermittent-pinning > mozilla-b2g:master

Finally, all green!

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8706277 [details] [review]
[gaia] albertopq:1232836-intermittent-pinning > mozilla-b2g:master

I know we are still seeing this test intermittently, but I think these changes need to land. Let's do this, land the changes and if the test gets a lot of stars we will re-disable it until we fix bug 1175116.

Comment 8

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/626d0bc59f3d079bfd09dd2c3c72e0ad9331717c

Comment 9

[Intermittent Failures Robot]

7 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 4
* b2g-inbound: 2
* try: 1

Platform breakdown:
* mulet-linux64: 7

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1232836&startday=2016-01-18&endday=2016-01-24&tree=all