Closed Bug 1232887 Opened 4 years ago Closed 4 years ago

"make package MOZ_PKG_PRETTYNAMES=1" is busted

Categories

(Firefox Build System :: General, defect, blocker)

defect
Not set
blocker

Tracking

(firefox44 fixed, firefox45 fixed, firefox46 fixed)

RESOLVED FIXED
mozilla46
Tracking Status
firefox44 --- fixed
firefox45 --- fixed
firefox46 --- fixed

People

(Reporter: rail, Assigned: rail)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch mozhareness_package_mkdir.diff (obsolete) — Splinter Review
Sorry, no mozreview setup on this laptop yet. :(

make package MOZ_PKG_PRETTYNAMES=1
 in dir /builds/slave/m-beta-m64-0000000000000000000/build/obj-firefox/x86_64 (timeout 1200 secs)
 watching logfiles {}
 argv: ['make', 'package', 'MOZ_PKG_PRETTYNAMES=1']
 environment:
  Apple_PubSub_Socket_Render=/tmp/launch-gvqrIj/Render
  CCACHE_COMPRESS=1
  CCACHE_DIR=/builds/ccache
  CCACHE_UMASK=002
  CHOWN_REVERT=~/bin/chown_revert
  CHOWN_ROOT=~/bin/chown_root
  DISPLAY=/tmp/launch-gsOtV3/org.x:0
  GIT_SHARE_BASE_DIR=/builds/git-shared
  HG_SHARE_BASE_DIR=/builds/hg-shared
  HOME=/Users/cltbld
  IDLEIZER_DISABLE_SHUTDOWN=true
  LC_ALL=C
  LOGNAME=cltbld
  MOZ_AUTOMATION=1
  MOZ_CRASHREPORTER_NO_REPORT=1
  MOZ_CURRENT_PROJECT=x86_64
  MOZ_OBJDIR=/builds/slave/m-beta-m64-0000000000000000000/build/obj-firefox
  MOZ_SYMBOLS_EXTRA_BUILDID=macosx64
  PATH=/tools/python/bin:/tools/buildbot/bin:/opt/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/usr/X11/bin
  POST_SYMBOL_UPLOAD_CMD=/usr/local/bin/post-symbol-upload.py
  PWD=/builds/slave/m-beta-m64-0000000000000000000/build/obj-firefox/x86_64
  RUNNER_CONFIG_CMD=/opt/runner/bin/python2.7 /opt/runner/bin/runner -c /opt/runner/runner.cfg
  SHELL=/bin/bash
  SSH_AUTH_SOCK=/tmp/launch-t1bPN7/Listeners
  SYMBOL_SERVER_HOST=symbolpush.mozilla.org
  SYMBOL_SERVER_PATH=/mnt/netapp/breakpad/symbols_ffx/
  SYMBOL_SERVER_SSH_KEY=/Users/cltbld/.ssh/ffxbld_rsa
  SYMBOL_SERVER_USER=ffxbld
  TINDERBOX_OUTPUT=1
  TMPDIR=/var/folders/4p/y5vzlw0d3d1fw9c3x8dbqg3r00000w/T/
  TOOLTOOL_CACHE=/builds/tooltool_cache
  TOOLTOOL_HOME=/builds
  TWISTD_LOG_PATH=/builds/slave/twistd.log
  USER=cltbld
  VERSIONER_PYTHON_PREFER_32_BIT=no
  VERSIONER_PYTHON_VERSION=2.7
  __CF_USER_TEXT_ENCODING=0x1C:0:0
 using PTY: False

make[2]: Nothing to be done for `export'.
make[2]: Nothing to be done for `compile'.
make[2]: Nothing to be done for `misc'.
make make-package-internal
OMNIJAR_NAME=omni.ja \
	NO_PKG_FILES="core bsdecho js js-config jscpucfg nsinstall viewer TestGtkEmbed elf-dynstr-gc mangle* maptsv* mfc* msdump* msmap* nm2tsv* nsinstall* res/samples res/throbber shlibsign* certutil* pk12util* BadCertServer* OCSPStaplingServer* GenerateOCSPResponse* chrome/chrome.rdf chrome/app-chrome.manifest chrome/overlayinfo components/compreg.dat components/xpti.dat content_unit_tests necko_unit_tests *.dSYM " \
	/builds/slave/m-beta-m64-0000000000000000000/build/obj-firefox/x86_64/_virtualenv/bin/python /builds/slave/m-beta-m64-0000000000000000000/build/toolkit/mozapps/installer/packager.py -DAB_CD=en-US -DNO_NSPR_10_SUPPORT -DMOZ_APP_NAME=firefox -DPREF_DIR=defaults/preferences -DJAREXT= -DMOZ_CHILD_PROCESS_NAME=plugin-container -DMOZ_SHARED_MOZGLUE=1 -DNECKO_WIFI -DDLL_PREFIX=lib -DDLL_SUFFIX=.dylib -DBIN_SUFFIX= -DDIR_MACOS=Contents/MacOS/ -DDIR_RESOURCES=Contents/Resources/ -DMOZ_FOLD_LIBS=1 -DAPPNAME=Nightly.app -DBINPATH=/Nightly.app/Contents/MacOS -DRESPATH=Nightly.app/Contents/Resources -DLPROJ_ROOT=en -DMOZ_ICU_VERSION=55 -DMOZ_ICU_DBG_SUFFIX= -DCLANG_CXX \
		--format omni \
		--removals /builds/slave/m-beta-m64-0000000000000000000/build/browser/installer/removed-files.in \
		 \
		 \
		 \
		 \
		--optimizejars \
		--unify /builds/slave/m-beta-m64-0000000000000000000/build/obj-firefox/x86_64/../i386/dist \
		/builds/slave/m-beta-m64-0000000000000000000/build/browser/installer/package-manifest.in ../../dist ../../dist/universal/firefox \
		
Executing ../../dist/bin/xpcshell -g /builds/slave/m-beta-m64-0000000000000000000/build/obj-firefox/x86_64/dist/Nightly.app/Contents/Resources -a /builds/slave/m-beta-m64-0000000000000000000/build/obj-firefox/x86_64/dist/Nightly.app/Contents/Resources -f /builds/slave/m-beta-m64-0000000000000000000/build/toolkit/mozapps/installer/precompile_cache.js -e precompile_startupcache("resource://gre/");
resource://gre/components/ActivityMessageConfigurator.js

.....

Duplicates 841 bytes:
  Nightly.app/Contents/Resources/res/table-remove-column.gif
  Nightly.app/Contents/Resources/res/table-remove-row.gif

WARNING: Found 41 duplicated files taking 238302 bytes (uncompressed)
# Package mozharness
/builds/slave/m-beta-m64-0000000000000000000/build/obj-firefox/x86_64/_virtualenv/bin/python -m mozbuild.action.test_archive  mozharness /builds/slave/m-beta-m64-0000000000000000000/build/obj-firefox/x86_64/dist/mac/en-US/mozharness.zip
Traceback (most recent call last):
  File "/tools/python/lib/python2.7/runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/tools/python/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/builds/slave/m-beta-m64-0000000000000000000/build/python/mozbuild/mozbuild/action/test_archive.py", line 332, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/builds/slave/m-beta-m64-0000000000000000000/build/python/mozbuild/mozbuild/action/test_archive.py", line 313, in main
    with open(args.outputfile, 'wb') as fh:
IOError: [Errno 2] No such file or directory: '/builds/slave/m-beta-m64-0000000000000000000/build/obj-firefox/x86_64/dist/mac/en-US/mozharness.zip'
make[3]: *** [stage-package] Error 255
make[2]: *** [make-package] Error 2
make[1]: *** [default] Error 2
make: *** [package] Error 2
Attachment #8698771 - Flags: review?(gps)
Comment on attachment 8698771 [details] [diff] [review]
mozhareness_package_mkdir.diff

in case if glandium can look at this earlier.
Attachment #8698771 - Flags: review?(mh+mozilla)
Comment on attachment 8698771 [details] [diff] [review]
mozhareness_package_mkdir.diff

Review of attachment 8698771 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/installer/packager.mk
@@ +55,5 @@
>  		$(if $(filter omni,$(MOZ_PACKAGER_FORMAT)),$(if $(NON_OMNIJAR_FILES),--non-resource $(NON_OMNIJAR_FILES)))
>  	$(PYTHON) $(MOZILLA_DIR)/toolkit/mozapps/installer/find-dupes.py $(DIST)/$(STAGEPATH)$(MOZ_PKG_DIR)
>  ifndef MOZ_THUNDERBIRD
>  	# Package mozharness
> +	$(NSINSTALL) -D $(DIST)/$(PKG_PATH)

I'd rather add an ensureParentDirectory in python/mozbuild/mozbuild/action/test_archive.py instead.
Attachment #8698771 - Flags: review?(mh+mozilla)
Attachment #8698771 - Flags: review?(gps)
testing this...
Attachment #8698771 - Attachment is obsolete: true
Comment on attachment 8698784 [details] [diff] [review]
mozhareness_package_ensureParentDir.diff

take 2
Attachment #8698784 - Flags: review?(mh+mozilla)
Attachment #8698784 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8698784 [details] [diff] [review]
mozhareness_package_ensureParentDir.diff

This is blocking beta 1 at the moment. It looks trivial enough to me.
Attachment #8698784 - Flags: approval-mozilla-beta?
Attachment #8698784 - Flags: approval-mozilla-aurora?
Arguably I should have landed it with a=rituwantedtowakeuptoagreentree, but then I would have had to stare at that to determine whether or not the word-breaks were unambiguous, and anyway I like to preserve our right to land anything we want as a=bustage during the interregnum on aurora and beta.
(In reply to Phil Ringnalda (:philor) from comment #8)
> Arguably I should have landed it with a=rituwantedtowakeuptoagreentree, but
> then I would have had to stare at that to determine whether or not the
> word-breaks were unambiguous, and anyway I like to preserve our right to
> land anything we want as a=bustage during the interregnum on aurora and beta.

LOL, you should have done it! :) Will rubberstamp as it did make the tree significantly green.
Attachment #8698784 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment on attachment 8698784 [details] [diff] [review]
mozhareness_package_ensureParentDir.diff

Rail said this is needed on Aurora too, a+
Attachment #8698784 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/b9e20e475147
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.