1232906 - Use channel.asyncOpen2 within dom/apps/AppsUtils.jsm

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Comment 1

[Christoph Kerschbaumer [:ckerschb}]

Attachment: bug_1232906_asyncopen2_dom_apps.patch

Even though this is the right fix we potentially have to wait with this bug to land till all we have investigated all of those callsites to pass a channel that was created using the right security flags before we can call asyncOpen2 on it.

Comment 2

[Christoph Kerschbaumer [:ckerschb}]

Comment on attachment 8698798 [details] [diff] [review]
bug_1232906_asyncopen2_dom_apps.patch

I think we can also land this callsite now.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d16cd4717c3b

Comment 4

[Nigel Babu [:nigelb]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3f5a7f35db7479643fd27850f7fe880aeb0c2cdd
Backed out changeset d16cd4717c3b (bug 1232906) for mochitest bustage

Comment 5

[Christoph Kerschbaumer [:ckerschb}]

Ok, apparently this one is not ready to land yet, we have to make sure those work:


373 INFO TEST-UNEXPECTED-FAIL | dom/apps/tests/test_app_addons.html | undefined assertion name - got "[object Object]", expected "MANIFEST_MISMATCH"
381 INFO TEST-UNEXPECTED-FAIL | dom/apps/tests/test_app_addons.html | unexpected installation error: [object Object]
383 INFO TEST-UNEXPECTED-FAIL | dom/apps/tests/test_app_addons.html | Checking alert message for http://mochi.test:8888/tests/dom/apps/tests/addons/index.html - got "Lorem ipsum", expected "Hello World!"
384 INFO TEST-UNEXPECTED-FAIL | dom/apps/tests/test_app_addons.html | Checking alert message for http://mochi.test:8888/tests/dom/apps/tests/addons/index.html - got "rgb(0, 0, 0)", expected "rgb(255, 0, 0)"
385 INFO TEST-UNEXPECTED-FAIL | dom/apps/tests/test_app_addons.html | Checking alert message for http://mochi.test:8888/tests/dom/apps/tests/addons/index.html - got "Uncustomized content", expected "Customized content" 


dom/tests/mochitest/fetch/test_fetch_app_protocol.html



1040 INFO TEST-UNEXPECTED-FAIL | dom/apps/tests/test_bug_945152.html | uncaught exception - TypeError: this.error is undefined at chrome://mochitests/content/chrome/dom/apps/tests/test_bug_945152.html:45
1049 INFO TEST-UNEXPECTED-FAIL | dom/apps/tests/test_operator_app_install.xul | Download error [object Object]

    928262 Intermittent TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/apps/tests/test_operator_app_install.xul | Test timed out.

1056 INFO TEST-UNEXPECTED-FAIL | dom/apps/tests/test_packaged_app_asmjs.html | uncaught exception - TypeError: this.error is undefined at chrome://mochitests/content/chrome/dom/apps/tests/test_packaged_app_asmjs.html:56

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ccb0b3153183

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ccb0b3153183