Closed
Bug 1232907
Opened 7 years ago
Closed 7 years ago
Enable ExecutableAllocator randomization on Windows XP
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(1 file)
2.30 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
Bug 700822 comment 4 mentions "frequent reftest failures" on Windows XP due to ExecutableAllocator randomization. The failures are not described in the bug and randomization was disabled in the patch. Four years later, however, I can no longer reproduce these reftest failures: https://treeherder.mozilla.org/#/jobs?repo=try&revision=76aa9db949d7 The orange test failures on XP are unrelated memory leaks.
Attachment #8698799 -
Flags: review?(jdemooij)
Comment 1•7 years ago
|
||
Comment on attachment 8698799 [details] [diff] [review] allow-ExecutableAllocator-randomization-on-XP.patch Review of attachment 8698799 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for doing this! ::: js/src/jit/ExecutableAllocatorWin.cpp @@ +221,5 @@ > ExecutableAllocator::systemAlloc(size_t n) > { > void* allocation = nullptr; > + void* randomAddress = computeRandomAllocationAddress(); > + allocation = AllocateExecutableMemory(randomAddress, n, initialProtectionFlags(Executable), Nit: we can now remove the |void* allocation = nullptr;| and declare it here: void* allocation = Allocate...
Attachment #8698799 -
Flags: review?(jdemooij) → review+
Comment 3•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d1de47ef53a2
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•