1232907 - Enable ExecutableAllocator randomization on Windows XP

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: allow-ExecutableAllocator-randomization-on-XP.patch

Bug 700822 comment 4 mentions "frequent reftest failures" on Windows XP due to  ExecutableAllocator randomization. The failures are not described in the bug and randomization was disabled in the patch. Four years later, however, I can no longer reproduce these reftest failures:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=76aa9db949d7

The orange test failures on XP are unrelated memory leaks.

Comment 1

[Jan de Mooij [:jandem]]

Comment on attachment 8698799 [details] [diff] [review]
allow-ExecutableAllocator-randomization-on-XP.patch

Review of attachment 8698799 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this!

::: js/src/jit/ExecutableAllocatorWin.cpp
@@ +221,5 @@
>  ExecutableAllocator::systemAlloc(size_t n)
>  {
>      void* allocation = nullptr;
> +    void* randomAddress = computeRandomAllocationAddress();
> +    allocation = AllocateExecutableMemory(randomAddress, n, initialProtectionFlags(Executable),

Nit: we can now remove the |void* allocation = nullptr;| and declare it here:

void* allocation = Allocate...

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d1de47ef53a2

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d1de47ef53a2