Closed
Bug 1232979
Opened 8 years ago
Closed 8 years ago
abs-pos/scrollframe-2.html fails on new linux64 docker container
Categories
(Taskcluster :: Services, defect)
Taskcluster
Services
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla46
People
(Reporter: jmaher, Assigned: jmaher)
References
Details
Attachments
(1 file)
1.81 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
this is the error we get in the log file: REFTEST TEST-UNEXPECTED-FAIL | file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/abs-pos/scrollframe-2.html | image comparison (==), max difference: 1, number of differing pixels: 1 you can see the difference here: http://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/Og4ayYWjQOC4dwpC3js6Rw/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1 I suspect this is a small issue similar to bug 1232316. For reference, the try run is here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0a238c213d3a (we care about R1 in this case) here is a link to the test file: https://dxr.mozilla.org/mozilla-central/source/layout/reftests/abs-pos/scrollframe-2.html and the reference: https://dxr.mozilla.org/mozilla-central/source/layout/reftests/abs-pos/scrollframe-2-ref.html this already has a lot of fuzzy conditions around it: https://dxr.mozilla.org/mozilla-central/source/layout/reftests/abs-pos/reftest.list#52 if we were to solve this with a fuzzy-if condition we could add: fuzzy-if(gtkWidget,1,1)
Assignee | ||
Comment 1•8 years ago
|
||
:ehsan, do you have ideas on the proper fix here? as you can see we have done some fuzzy-if in the past. Other techniques are to increase the font size. maybe in this case we have incorrect font packages.
Flags: needinfo?(ehsan)
Comment 2•8 years ago
|
||
I guess you can adjust the fuzzy pixel count or some such.
Flags: needinfo?(ehsan)
Assignee | ||
Comment 3•8 years ago
|
||
going the simple route of adding a fuzzy-if for linux. Tested that this doesn't affect our existing automation and fixes our new automation.
Comment 4•8 years ago
|
||
Comment on attachment 8699406 [details] [diff] [review] add fuzzy-if for failing test case Review of attachment 8699406 [details] [diff] [review]: ----------------------------------------------------------------- rs=me
Attachment #8699406 -
Flags: review?(ehsan) → review+
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f569c7e03c23
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Comment 7•8 years ago
|
||
Moving closed bugs across to new Bugzilla product "TaskCluster".
Updated•5 years ago
|
Component: Integration → Services
You need to log in
before you can comment on or make changes to this bug.
Description
•