1232981 - bidi/83958-1*.html reftests fail on new linux64 docker container

Status: RESOLVED FIXED

(Taskcluster :: Services, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

in pushing to try where we run taskcluster jobs in a docker container, we have some reftest failures:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0a238c213d3a&filter-searchStr=r1


REFTEST TEST-UNEXPECTED-FAIL | file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/bidi/83958-1a.html | image comparison (==), max difference: 1, number of differing pixels: 12
REFTEST TEST-UNEXPECTED-FAIL | file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/bidi/83958-1b.html | image comparison (==), max difference: 1, number of differing pixels: 18
REFTEST TEST-UNEXPECTED-FAIL | file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/bidi/83958-1c.html | image comparison (==), max difference: 1, number of differing pixels: 18 

reftest analyzer shows a slight difference (not very easy to see to the eye):
http://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/Og4ayYWjQOC4dwpC3js6Rw/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1


If we wanted to adjust the manifest for fuzzing, we would add:
fuzzy-if(gtkWidget,1,12) and fuzzy-if(gtkWidget,1,18)

right now these tests have no existing fuzzy-if statements in the manifest:
https://dxr.mozilla.org/mozilla-central/source/layout/reftests/bidi/reftest.list#50

an example of the 1a test-
test: https://dxr.mozilla.org/mozilla-central/source/layout/reftests/bidi/83958-1a.html
ref: https://dxr.mozilla.org/mozilla-central/source/layout/reftests/bidi/83958-1-ref.html

Comment 1

[Armen [:armenzg]]

Should we NI for this bug? or not yet?

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

What's "NI"?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It might make sense to just add some letter-spacing (maybe 1px or 2px) to the tests, assuming that that works...

Comment 4

[Armen [:armenzg]]

NI: needinfo

Hi David! I hadn't checked the CC list. Thanks for your input!

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

I couldn't get letter-spacing: 1|2px working for either the test and/or the reference.  I did try adding:
body { font-size: 300%; }

this added to both the test and the reference proves success.  This is a suggestion that was said in bug 1232980 and it worked there.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add font-size:300 to the body to reduce fuzzy painting

:dbaron, if you don't like this approach of font-size, then please cancel the review.  I can easily reproduce/hack on this locally if you have other suggestions or preferences.  Otherwise it will be nice to get this in!

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Did you check that the test still fits within the window (i.e., the screenshotted area)?

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

ok, figured out how to get this by dumping the dodataUrl() for successful tests and then putting that into a img src:
http://people.mozilla.org/~jmaher/bidi.html

Please let me know if there is a better way to do this and if this answers your question.  I believe this is showing all the data we expect.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8701063 [details] [diff] [review]
add font-size:300 to the body to reduce fuzzy painting

r=dbaron if you also add:

p { margin: 0 }

so that it will still fit if/when we switch to 600x600


(The easy way to look at the images is to change the test to a != and look at the failure in reftest-analyzer.xhtml.)

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6b5c53463b1e

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6b5c53463b1e

Comment 12

[Pete Moore [:pmoore][:pete]]

Moving closed bugs across to new Bugzilla product "TaskCluster".