1233195 - Using PAC causes us to not test what we ship in the HTTP stack in mochitests

Status: NEW

(Core :: Networking: Proxy, defect, P5)

Description

[(no longer active)]

We found out about this when debugging bug 1219469.

This is the code in question: <https://dxr.mozilla.org/mozilla-central/source/netwerk/base/nsProtocolProxyService.cpp?case=true&from=nsProtocolProxyService%3A%3AAsyncResolveInternal#1303>.  In cases where we are not using PAC, we may end up resolving the host synchronously, but where we're using PAC (specifically in mochitests) we never enter that condition branch, so irrespective of what isSyncOK is, we always resolve the name asynchronously.

We believe that this is the reason why bug 1219469 went undetected with the existing mochitests in the tree.  We found out about this crash by people hitting it in the wild, and also a web-platform-test which also triggered the crash since that test suite doesn't use PAC.

It would be nice if we somehow made it so that mochitests somehow not use PAC, or alternatively eliminate the possibly synchronous path added in bug 887995, so that our mochitests test the HTTP stack in the default state similar to what we ship.

Comment 1

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258