1233274 - [EME] Don't shutdown detached MediaKeys

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: detach-and-use-mediakeys.html

Chrome doesn't shutdown a MediaKeys object which is attached to an HTMLMediaElement when a new MediaKeys is set on said HTMLMediaElement.

See attached testcase; we reject the MediaKeySession.generateRequest promise, Chrome does not.

Note the spec gives us wiggle room to choose what to do here. I think we should try to match Chrome and not shutdown the MediaKeys.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

I note that Chrome refuses to allow the MediaKeys to be reset if its already loaded a resource in the media element.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

We can basically take this opportunity to update our HTMLMediaElement.setMediaKeys() implementation to match the current spec:
http://www.w3.org/TR/encrypted-media/#widl-HTMLMediaElement-setMediaKeys-Promise-void--MediaKeys-mediaKeys

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: MozReview Request: Bug 1233274 - Don't shutdown detached MediaKeys. r?gerald

Review commit: https://reviewboard.mozilla.org/r/29659/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29659/

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8704410 [details]
MozReview Request: Bug 1233274 - Don't shutdown detached MediaKeys. r?gerald

https://reviewboard.mozilla.org/r/29659/#review26479

r+ after typo is fixed:

::: dom/media/test/test_eme_detach_media_keys.html:38
(Diff revision 1)
> +// after the second MediaKeys has been se on the media element.

"se" -> "set"

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ef39bda60d33

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ef39bda60d33