1233367 - Right-border of current time label has wrong color with the dark-theme

Status: VERIFIED FIXED

(DevTools :: Inspector: Animations, defect)

Description

[Patrick Brosset <:pbro>]

Attachment: toolbar-border-color.PNG

STR:
- Open the inspector on about:home
- Make sure you use the dark theme (in the devtools options panel, switch to it if necessary)
- Switch to the animation-inspector sidebar panel
- Hover over any of the buttons at the bottom of the page to trigger animations

==> The color of the last border in the toolbar that contains the rewind/pause/rate/time buttons/labels is wrong (see attachment).

To fix this, I believe we should:

- add the class devtools-toolbarbutton to the #timeline-current-time element in devtools\client\animationinspector\animation-inspector.xhtml
- remove the hard-coded border color: border-color: rgba(170, 170, 170, .5);
in the #global-toolbar .label, #timeline-toolbar .label rule in devtools\client\themes\animationinspector.css

Comment 1

[simplyblue24]

Hi, can you assign the bug to me. I like to work on it.Thanks :)

Comment 2

[simplyblue24]

Attachment: 1233367.patch

Hi, can you please review my patch.Thanks :)

Comment 3

[Patrick Brosset <:pbro>]

Thanks for working on this. Assigning the bug to you now. I'll test this now and review the changes.

Comment 4

[Patrick Brosset <:pbro>]

Comment on attachment 8699879 [details] [diff] [review]
1233367.patch

Review of attachment 8699879 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me thanks!

Comment 5

[Patrick Brosset <:pbro>]

Will push this to fx-team since this does not require a try build first.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/b32c4163ff05

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b32c4163ff05

Comment 8

[Khalid Syfullah Zaman [:khalid32]]

I have reproduced this bug on Nightly 46.0a1 (2015-12-17) on ubuntu 14.04 LTS, 32 bit!

The bug's fix is now verified on Latest Nightly 46.0a1!

Build ID: 20160105030211
User Agent: Mozilla/5.0 (X11; Linux i686; rv:46.0) Gecko/20100101 Firefox/46.0

Comment 9

[Rezaul Huque Nayeem]

Reproduced the bug in firefox nightly 46.0a1 (2015-12-17) with windows 10 (64 bit)

Verified as fixed with latest firefox nightly 46.0a1 (Build ID: 20160112030227)

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:46.0) Gecko/20100101 Firefox/46.0

As it is also verified on Linux (Comment 8), Marking it as verified!