1233414 - Bookmarking a URL that redirects to something else results in a null bookmark

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect, P5)

Description

[Andrei Vaida [:avaida]]

Attachment: screenshot from Ubuntu 14.04 (x64)

Reproducible on:
- 44.0b1-build1 (20151216164151)
- 43.0.1-build1 (20151216175450)
- 42.0-build2 (20151029151421)
- 46.0a1 (2015-12-16)

Affected platforms:
- Windows 7 x86
- Windows 10 x64
- Mac OS X 10.11
- Ubuntu 14.04 x64

Steps to reproduce:
1. Launch Firefox.
2. Enable the Bookmarks Toolbar and the History Sidebar.
3. Access a URL that will redirect you even slightly, e.g. https://www.mozilla.org/en-US/firefox/central/ or reddit.com
4. From the History Sidebar, drag and drop that URL to the Bookmarks Toolbar.

Expected result:
A bookmark is created for the initial URL, with a favicon and a label displayed on the toolbar.

Actual result:
- A null bookmark is created for the initial URL, only displaying the favicon on the toolbar.
- Note that older version, e.g. 37.0a2 display the favicon and the label 'null' instead, which is still bad.

Additional notes:
- I've tried to isolate a regression range, but this issue is reproducible all the way back to 27.0a1 (and older), so I'm pretty sure it's been there for a while now.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

This regressed in Firefox 4.

Regression range: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2eb351cc47d3&tochange=6628da386550

Looks like a regression from bug 519479.

Comment 2

[Marco Bonardo [:mak]]

we never supported properly bookmarks that redirect (there's a bug filed from a long time for that)... so what's the regression about, the fact we show nothing instead of "null" as the label? that's actually a fix, not a regression.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

The old behavior was that it showed part of the URL next to the favicon, i.e. "en-US/firefox/central/" whereas now it shows nothing at all next to it.

Comment 4

[Marco Bonardo [:mak]]

yes, bug 519479 changed that on purpose so one can set an empty title on a bookmark and just retain the favicon on the toolbar. I'm not sure we can easily detect if the user left an empty title on purpose or not, but it's also easy to change it for the user.

Comment 5

[Dana Lucaci, Desktop QA]

This issue is not reproducible anymore using the latest Firefox 123.0 build on macOS 12 ARM, Win 10 and Ubuntu 22. I'm closing it as WFM.