1233423 - [Static Analysis][Logically dead code] In function nsStyleUtil::AppendStepsTimingFunction from nsStyleUtil.cpp

Status: RESOLVED WONTFIX

(Core :: CSS Parsing and Computation, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity added in case when aSyntax == nsTimingFunction::StepSyntax::Keyword the following code is useless:

>>    case nsTimingFunction::StepSyntax::Keyword:
>>      // handled above
>>      break;

because earlier in function this code block is present

>>  if (aSyntax == nsTimingFunction::StepSyntax::Keyword) {
>>    if (aType == nsTimingFunction::Type::StepStart) {
>>      aResult.AppendLiteral("step-start");
>>    } else {
>>      aResult.AppendLiteral("step-end");
>>    }
>>    return;
>>  }

I propose to eliminate the useless code.

Comment 1

[Andi [:andi]]

Attachment: Bug 1233423.diff

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8699479 [details] [diff] [review]
Bug 1233423.diff

This code probably exists to silence a compiler warning.

I probably favor leaving it as it is, since I consider compiler warnings more valuable than Coverity warnings.

Comment 3

[Andi [:andi]]

OK thank you David!

Comment 4

[Cameron McCormack (:heycam)]

Yes, that produces a warning (and an error if --enable-warnings-as-errors) due to not handling all enum values in the switch statement.