Closed
Bug 1233524
Opened 10 years ago
Closed 10 years ago
The Create Profile Wizard says "Click Done ..." when the button is called "Finish" and "Click Finish ..." when the button is called "Done"
Categories
(Toolkit :: Startup and Profile System, defect)
Toolkit
Startup and Profile System
Tracking
()
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: philip.chee, Assigned: philip.chee)
References
Details
Attachments
(1 file)
1.30 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
STR:
1. Go to about:profiles
2. Click on "Create a New Profile"
3. Click on [Next]
> -#ifndef XP_MACOSX
This is a if*n*def
> - finishText.firstChild.data = gProfileManagerBundle.getString("profileFinishText");
> -#else
> - finishText.firstChild.data = gProfileManagerBundle.getString("profileFinishTextMac");
> -#endif
> + if (AppConstants.platform == "macosx") {
This should be:
if (AppConstants.platform != "macosx")
![]() |
Assignee | |
Comment 1•10 years ago
|
||
![]() |
||
Comment 2•10 years ago
|
||
Comment on attachment 8700324 [details] [diff] [review]
Fix logic to show the correct L10n
Looks right based on the original change -
http://hg.mozilla.org/mozilla-central/diff/2489a4b3a2a5/toolkit/profile/content/createProfileWizard.js
Attachment #8700324 -
Flags: review?(jmathies) → review+
![]() |
Assignee | |
Comment 3•10 years ago
|
||
Comment 4•10 years ago
|
||
Note: for future patches, please make your commit message describe the change, instead of simply quoting the bug title:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Committing_Rules_and_Responsibilities#Checkin_comment
Comment 5•10 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•