1233535 - Show the user's email and display name in Sync preferences when available

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P2)

Description

[Ryan Feeley [:rfeeley]]

Attachment: smaller.png

When the display name is available, show it above with a smaller (13px) email address and make the avatar bigger (80px).

Comment 1

[Lina Butler [:lina]]

Picking this up again.

Comment 2

[Lina Butler [:lina]]

Attachment: Screen Shot 2016-03-04 at 3.15.19 PM.png

I haven't tested this out on Windows or Linux yet, but how do these proportions look to you, Ryan? The avatar is 96x96.

Comment 3

[Lina Butler [:lina]]

Um, why did I write "96x96"? I meant 80x80, per your request in comment 0. :-)

Comment 4

[Ryan Feeley [:rfeeley]]

Thanks Kit! The avatar looks too big. The goal is to have the bottom of it line up with the bottom of the button.

Comment 5

[Lina Butler [:lina]]

Comment on attachment 8726966 [details]
Screen Shot 2016-03-04 at 3.15.19 PM.png

Cool, will do!

Comment 6

[Lina Butler [:lina]]

Attachment: MozReview Request: Bug 1233535 - Show the user's email and display name in Sync preferences when available. r=markh

Review commit: https://reviewboard.mozilla.org/r/43633/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43633/

Comment 7

[Lina Butler [:lina]]

Attachment: Avatar states.png

What do you think, Ryan?

Comment 8

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8737002 [details]
MozReview Request: Bug 1233535 - Show the user's email and display name in Sync preferences when available. r=markh

https://reviewboard.mozilla.org/r/43633/#review40223

LGTM, but please wait for Ryan's thumbs up

Comment 9

[Ryan Feeley [:rfeeley]]

Can you make the default avatar scale up too when the display name is present? I am pretty sure it's SVG so it shouldn't be a problem making it the same size as the custom avatar.

Comment 10

[Lina Butler [:lina]]

Unfortunately, it looks like it's a PNG; that's why I scaled it down. :-/ https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/fxa/default-avatar.png

Is there an SVG version you'd like for me to use instead?

Comment 11

[Ryan Feeley [:rfeeley]]

https://accounts.firefox.com/images/0e592e73.default-profile.svg

Comment 12

[Lina Butler [:lina]]

Comment on attachment 8737002 [details]
MozReview Request: Bug 1233535 - Show the user's email and display name in Sync preferences when available. r=markh

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43633/diff/1-2/

Comment 13

[Lina Butler [:lina]]

Attachment: Bigger default avatar.png

Comment 14

[Ryan Feeley [:rfeeley]]

Close. Only needs to be bigger when there is a name, not all the time. See the original design (just imagine the avatar is default there too). https://bug1233535.bmoattachments.org/attachment.cgi?id=8699614

Comment 15

[Lina Butler [:lina]]

Attachment: Avatar states.png

OK! Sorry for the churn, Ryan; I didn't realize that we should keep the "Current" design if we don't have a display name.

Comment 16

[Ryan Feeley [:rfeeley]]

Comment on attachment 8737434 [details]
Avatar states.png

Excellent!

Comment 17

[Lina Butler [:lina]]

Comment on attachment 8737002 [details]
MozReview Request: Bug 1233535 - Show the user's email and display name in Sync preferences when available. r=markh

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43633/diff/2-3/

Comment 18

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/d080043beed9

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d080043beed9

Comment 20

[Nazir Ahmed Sabbir [:NaSb]]

I've managed to reproduce this bug on Nightly 46.0a1 (2015-12-17) ; 
(Build ID: 20151217030207) on Linux, 64 Bit.

This Bug is now verified as fixed on Latest Firefox Developer Edition 48.0a2 (2016-05-11)

Build ID: 20160511004106
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0
OS: Linux 3.19.0-58-generic x86-64