Show the user's email and display name in Sync preferences when available

RESOLVED FIXED in Firefox 48

Status

()

Firefox
Sync
P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: rfeeley, Assigned: kitcambridge)

Tracking

unspecified
Firefox 48
Points:
---
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(firefox48 fixed)

Details

(Whiteboard: [qx:link])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments, 3 obsolete attachments)

(Reporter)

Description

2 years ago
Created attachment 8699614 [details]
smaller.png

When the display name is available, show it above with a smaller (13px) email address and make the avatar bigger (80px).

Updated

2 years ago
Flags: firefox-backlog+
(Reporter)

Updated

2 years ago
Whiteboard: [qx:link]
Assignee: nobody → kcambridge
Priority: -- → P1
Status: NEW → ASSIGNED
Assignee: kcambridge → nobody
Status: ASSIGNED → NEW
Picking this up again.
Assignee: nobody → kcambridge
Created attachment 8726966 [details]
Screen Shot 2016-03-04 at 3.15.19 PM.png

I haven't tested this out on Windows or Linux yet, but how do these proportions look to you, Ryan? The avatar is 96x96.
Attachment #8726966 - Flags: feedback?(rfeeley)
Um, why did I write "96x96"? I meant 80x80, per your request in comment 0. :-)
Status: NEW → ASSIGNED
(Reporter)

Comment 4

2 years ago
Thanks Kit! The avatar looks too big. The goal is to have the bottom of it line up with the bottom of the button.
Flags: needinfo?(kcambridge)
(Reporter)

Updated

2 years ago
Flags: needinfo?(kcambridge)
Comment on attachment 8726966 [details]
Screen Shot 2016-03-04 at 3.15.19 PM.png

Cool, will do!
Attachment #8726966 - Flags: feedback?(rfeeley)

Updated

2 years ago
Blocks: 1257995

Updated

2 years ago
Priority: P1 → P2
Created attachment 8737002 [details]
MozReview Request: Bug 1233535 - Show the user's email and display name in Sync preferences when available. r=markh

Review commit: https://reviewboard.mozilla.org/r/43633/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43633/
Attachment #8737002 - Flags: review?(markh)
Created attachment 8737003 [details]
Avatar states.png

What do you think, Ryan?
Attachment #8726966 - Attachment is obsolete: true
Attachment #8737003 - Flags: feedback?(rfeeley)

Updated

2 years ago
Attachment #8737002 - Flags: review?(markh) → review+
Comment on attachment 8737002 [details]
MozReview Request: Bug 1233535 - Show the user's email and display name in Sync preferences when available. r=markh

https://reviewboard.mozilla.org/r/43633/#review40223

LGTM, but please wait for Ryan's thumbs up
(Reporter)

Comment 9

2 years ago
Can you make the default avatar scale up too when the display name is present? I am pretty sure it's SVG so it shouldn't be a problem making it the same size as the custom avatar.
Flags: needinfo?(kcambridge)
Unfortunately, it looks like it's a PNG; that's why I scaled it down. :-/ https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/fxa/default-avatar.png

Is there an SVG version you'd like for me to use instead?
Flags: needinfo?(kcambridge)
Comment on attachment 8737002 [details]
MozReview Request: Bug 1233535 - Show the user's email and display name in Sync preferences when available. r=markh

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43633/diff/1-2/
Attachment #8737002 - Attachment description: MozReview Request: Bug 1233535 - Show the user's email and display name in Sync preferences when available. r?markh → MozReview Request: Bug 1233535 - Show the user's email and display name in Sync preferences when available. r=markh
Created attachment 8737376 [details]
Bigger default avatar.png
Attachment #8737376 - Flags: feedback?(rfeeley)
(Reporter)

Comment 14

2 years ago
Close. Only needs to be bigger when there is a name, not all the time. See the original design (just imagine the avatar is default there too). https://bug1233535.bmoattachments.org/attachment.cgi?id=8699614
Created attachment 8737434 [details]
Avatar states.png

OK! Sorry for the churn, Ryan; I didn't realize that we should keep the "Current" design if we don't have a display name.
Attachment #8737003 - Attachment is obsolete: true
Attachment #8737376 - Attachment is obsolete: true
Attachment #8737003 - Flags: feedback?(rfeeley)
Attachment #8737376 - Flags: feedback?(rfeeley)
Attachment #8737434 - Flags: feedback?(rfeeley)
(Reporter)

Comment 16

2 years ago
Comment on attachment 8737434 [details]
Avatar states.png

Excellent!
Attachment #8737434 - Flags: feedback?(rfeeley) → feedback+
Comment on attachment 8737002 [details]
MozReview Request: Bug 1233535 - Show the user's email and display name in Sync preferences when available. r=markh

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43633/diff/2-3/

Comment 19

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d080043beed9
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
I've managed to reproduce this bug on Nightly 46.0a1 (2015-12-17) ; 
(Build ID: 20151217030207) on Linux, 64 Bit.

This Bug is now verified as fixed on Latest Firefox Developer Edition 48.0a2 (2016-05-11)

Build ID: 20160511004106
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0
OS: Linux 3.19.0-58-generic x86-64
QA Whiteboard: [bugday-20160511]
You need to log in before you can comment on or make changes to this bug.