1233622 - [meta][OTA]Separate Gecko and Gonk layers for accessing Androids properties

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: General, defect)

Description

[Edgar Chen [:edgar]]

This bug is used to track a general solution for accessing Android properties.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Gonk's internal implementation [1] uses |socket| and |send| and could therefore block. We currently call this on the main thread in a few places, although it could possibly block.

I suggest to add an asynchronous HAL interface for |property_get| and |property_set|. Framework code is in ipc/hal/, example code is in dom/bluetooth/bluedroid/. The operations can then run on a separate thread or in a separate system service.

A plain linux solution might be build on D-Bus and dconf, which would also require an asynchronous design.

I guess we'll also need a nice JS interface for JS code, such as RIL.

[1] https://android.googlesource.com/platform/bionic/+/master/libc/bionic/system_properties.cpp

Comment 2

[Bevis Tseng[:bevis][:btseng](Exited)]

Set assignee to myself to follow up this bug.

Comment 3

[Bevis Tseng[:bevis][:btseng](Exited)]

Reset assignee.
More likely to be a meta bug instead.
property_get/property_set is used widely in various modules in gonk-enabled projects:
https://dxr.mozilla.org/mozilla-central/search?q=regexp%3Aproperty_%28get|set%29&redirect=false&case=true

Need more discussion to break down the task.

Comment 4

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

Just had a discussion with other module peers/EMs, it turns out that several modules have their plans to isolate vendor libraries from gecko and have various use cases, so we decided the bug will simply focus on RIL usage.

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Hi

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #4)
> Just had a discussion with other module peers/EMs, it turns out that several
> modules have their plans to isolate vendor libraries from gecko and have
> various use cases, so we decided the bug will simply focus on RIL usage.

Hmm, this bug isn't about general libraries, but the property mechanism. Can we open a separate bug report for RIL and keep this one as meta bug for the properties?

Comment 6

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #5)
> Hi
> 
> (In reply to Hsin-Yi Tsai [:hsinyi] from comment #4)
> > Just had a discussion with other module peers/EMs, it turns out that several
> > modules have their plans to isolate vendor libraries from gecko and have
> > various use cases, so we decided the bug will simply focus on RIL usage.
> 
> Hmm, this bug isn't about general libraries, but the property mechanism. Can
> we open a separate bug report for RIL and keep this one as meta bug for the
> properties?

sure.

Comment 7

[Ethan Tseng [:ethan]]

No plan to work on this bug anymore.