1233644 - use pattern matching when listening clear-origin-data in ServiceWorkerManager

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

See Honza's comment in https://bugzilla.mozilla.org/show_bug.cgi?id=1233136#c0

"ServiceWorkerManager [2], bug 1191647, that doesn't build OriginAttributesPattern from aData"

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: WIP Patch

WIP, still have problems on writing tests.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=680b69b15865

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch.

Thanks to :kanru's help, I get the tests running. :D

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4f533ad0b90

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch

fixed some try failure

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch.

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8700932 [details] [diff] [review]
Patch.

Review of attachment 8700932 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Ben
The handling of clear-origin-data landed in Bug 1191647 has some problems,
for example, when the data is {appId: 1} in clear-origin-data,
we should clear all registrations for appId = 1, whether the inBrowser flag is true or not.
Right now the code will only clear the registration {appId: 1, inBrowser: false}

Also test is included, 
in the test I need a mozbrowser frame which needs 'browser' permission,
to prevent adding more permissions into the original app,
so I create another test app, which is copied the test app from dom/workers/test/serviceworkers/app/

Could you review this for me?

Thanks

Comment 8

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8700932 [details] [diff] [review]
Patch.

Review of attachment 8700932 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, I'm buried trying to get a beta crasher fixed before going on holiday.  Andrea, can you take this review?

::: dom/workers/test/serviceworkers/app3/sw.js
@@ +1,1 @@
> +// Useless service worker.

Please use: dom/workers/test/serviceworkers/empty.js

Comment 9

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d76b3c273046

Comment 10

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch. v2

use empty.js

Comment 11

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/b53aa421ca199c5bf3504b74c0b80af06a69e8b9
Bug 1233644 - use pattern matching when listening clear-origin-data. r=baku

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b53aa421ca19