1233657 - [GUI] stopping bisection while the build is installed does not work

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[Julien Pagès (:parkouss)]

Steps to reproduce:

1. Start a bisection with the GUI
2. when you see "Running mozilla-central build for ..." in the log view, wait one second, then click to stop the bisection

Firefox will still be launched, and you will get prompted to evaluate the build.

Comment 1

[Julien Pagès (:parkouss)]

Attachment: allow to quit properly the bisection if stopped during install step

So, this should fix it - works for me at least. :)

The second patch is not directly related, but it will help for the future.

Comment 2

[William Lachance (:wlach)]

Comment on attachment 8699950 [details] [review]
allow to quit properly the bisection if stopped during install step

LGTM

Comment 3

[MikeLing]

Comment on attachment 8699950 [details] [review]
allow to quit properly the bisection if stopped during install step

I still seeing the unable to stop the application error shows up,

> 2015-12-21T20:23:08: INFO : platform_version: 41.0a1
> 2015-12-21T20:23:12: INFO : Shumway is registered
> 2015-12-21T20:23:14: ERROR : Unable to stop the application
> 2015-12-21T20:23:14: INFO : Narrowed nightly regression window from [2014-12-21, 2015-12-20] (364 days) to [2015-06-21, 2015-12-20] (182 days) (~7 steps left)

Not sure why, but this PR looks good for me anyway :)

Comment 4

[Julien Pagès (:parkouss)]

Thanks, landed in https://github.com/mozilla/mozregression/commit/c51e7bc7f00374994d0afdf2e0fcc341f50359ee.