Intermittent tp5o_scroll,tsvgx | Failed to convert value None of type NoneType for field exitcode to type Int

RESOLVED FIXED in Firefox 46

Status

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: nigelb, Assigned: parkouss)

Tracking

({intermittent-failure})

unspecified
mozilla46
Points:
---

Firefox Tracking Flags

(firefox46 fixed)

Details

()

Attachments

(1 attachment)

https://treeherder.mozilla.org/logviewer.html#?job_id=18757104&repo=mozilla-inbound



 00:17:55     INFO -  PROCESS | 3460 | Values: 1639.0  1611.0  1589.0  1631.0  1587.0  1617.0  1623.0  1613.0  1605.0  1591.0  1617.0  1611.0  1628.0  1624.0  1663.0  1593.0  1606.0  1586.0  1604.0  1631.0  1602.0  1638.0  1589.0  1633.0  1775.0
 00:17:55     INFO -  PROCESS | 3460 | -------- Summary: end --------
 00:17:55     INFO -  PROCESS | 3460 |
 00:18:03     INFO -  Browser shutdown timed out after 5 seconds, terminating process.
 00:18:03     INFO -  Terminating psutil.Process(pid=3460, name='firefox')
 00:18:03     INFO -  TEST-UNEXPECTED-ERROR | tsvgx | Failed to convert value None of type NoneType for field exitcode to type Int
 00:18:03    ERROR -  Traceback (most recent call last):
 00:18:03     INFO -    File "/builds/slave/test/build/tests/talos/talos/run_tests.py", line 196, in run_tests
 00:18:03     INFO -      talos_results.add(mytest.runTest(browser_config, test))
 00:18:03     INFO -    File "/builds/slave/test/build/tests/talos/talos/ttest.py", line 64, in runTest
 00:18:03     INFO -      return self._runTest(browser_config, test_config, setup)
 00:18:03     INFO -    File "/builds/slave/test/build/tests/talos/talos/ttest.py", line 176, in _runTest
 00:18:03     INFO -      if counter_management else None),
 00:18:03     INFO -    File "/builds/slave/test/build/tests/talos/talos/talos_process.py", line 138, in run_browser
 00:18:03     INFO -      LOG.process_exit(proc.pid, return_code)
 00:18:03     INFO -    File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/mozlog/logtypes.py", line 46, in inner
 00:18:03     INFO -      data = converter.convert(*args, **kwargs)
 00:18:03     INFO -    File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/mozlog/logtypes.py", line 88, in convert
 00:18:03     INFO -      out_value = self.args[key](value)
 00:18:03     INFO -    File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/mozlog/logtypes.py", line 121, in __call__
 00:18:03     INFO -      (value, type(value).__name__, self.name, self.__class__.__name__))
 00:18:03     INFO -  ValueError: Failed to convert value None of type NoneType for field exitcode to type Int
 00:18:03     INFO -  TEST-INFO took 442310ms
 00:18:03     INFO -  SUITE-END | took 442s
 00:18:03    ERROR - Return code: 2
 00:18:03  WARNING - setting return code to 2
 00:18:03    ERROR - # TBPL FAILURE #
:parkouss, interesting bug here- I wonder if we have some exception happening in the counters which we were silently ignoring before.
(In reply to Joel Maher (:jmaher) from comment #1)
> :parkouss, interesting bug here- I wonder if we have some exception
> happening in the counters which we were silently ignoring before.

Well maybe - but that is not the root case. This is related to my mozlog patch. Basically I report the exit code, but looks like it was None. I remember now that sometimes it is (I'm sorry I did not think about that sooner...). I don't know exactly why, but I suspect a mozprocess/mozrunner bug.

I will look at it, the easiest way to fix it would be for now to not log the end of the process if the return code is None.
bug 1229379 (that caused the problems here) got backed out now
See Also: → 1229379
This should fix the issue. The above try looks good to me.
Assignee: nobody → j.parkouss
Status: NEW → ASSIGNED
Attachment #8699992 - Flags: review?(jmaher)
Comment on attachment 8699992 [details] [diff] [review]
talos failure when firefox exit code is not detected

Review of attachment 8699992 [details] [diff] [review]:
-----------------------------------------------------------------

solid cleanup here.
Attachment #8699992 - Flags: review?(jmaher) → review+
OK, we should be good. Landing soon.
https://hg.mozilla.org/mozilla-central/rev/e8b9203ad41e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.