Closed Bug 1233686 Opened 8 years ago Closed 8 years ago

--profile folder is created, but not used

Categories

(Testing :: mozregression, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: elbart, Assigned: parkouss)

Details

Attachments

(1 file)

49 bytes, text/x-github-pull-request
wlach
: review+
Details | Review
mozregression 2.0.1 

When I define a profile-folder with --profile to be used across all steps, mozregression is creating that folder, but it's not using it.

Instead it's using a temporary profile, which is recreated everytime.

Tried with --profile=test and --profile=/c/users/user/test
Component: Developer Tools → mozregression
Product: Firefox → Testing
That is the normal behavior.

By default, the profile is cloned each time.

If you want to reuse it, you should use the "--profile-persistence" option, with the value "clone-first" or "reuse".

"clone-first" do only one clone of the profile (for the first build run), then reuse that clone. "reuse" directly use the given profile (no clone at all). But be aware that mozregression defines some preferences on the profile, so if you use "reuse" your initial profile will be impacted.

See |mozregression --help|.

Elbart, does that help ?

As a side note, I think we *should* write some documentation/examples about that in the documentation.

Second side note, you might now be facing Bug 1233649... I'm working on it. Though I can help you to hack around this if you are in a hurry.
Flags: needinfo?(elbart)
When mozregression is creating that folder, isn't it then cloning an empty folder all the time?

Haven't used mozreg in months, so I had no idea of that new profile-behavior. Thanks.
Flags: needinfo?(elbart)
Status: UNCONFIRMED → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
(In reply to Elbart from comment #2)
> When mozregression is creating that folder, isn't it then cloning an empty
> folder all the time?

Hm, good question - NI'ing myself to look into that later. By the way, I guess you can use --profile-persistence=clone-first without giving a --profile value for what you want to achieve I guess (this will create a fresh profile, and reuse it across next builds).

Also, eventually you can put that in your configuration file if you want it as a default, http://mozilla.github.io/mozregression/documentation/configuration.html#example.

> Haven't used mozreg in months, so I had no idea of that new
> profile-behavior. Thanks.

You're welcome! :)
Flags: needinfo?(j.parkouss)
I tried it. When mozregression is given a profile dir that do not exists, that profile dir is only used when the persistence is set to reuse.

As Elbart described, in other case the dir is created - but not used at all.

I am thinking that in this case, we could keep the profile dir (The user gave a path after all, he is probably looking to see something in that directory). I must say I can't see much interest in keeping a profile dir with clone persistence method (we will copy next profiles from a fresh one, roughly - exactly ? - equivalent to let mozprofile create new ones from scratch), but I may be missing something that could be important for users.

The other option would be to disallow giving a non existing directory, as everything can be done with the combination of profile / profile-persistence I think.

Oh well - I choose the first option: keep the persist dir, along with a warning (in case the user wanted to use an existing profile, but made a typo in the path). Please tell me if you disagree. :)

I reopen this bug to make the change.
Status: RESOLVED → REOPENED
Ever confirmed: true
Flags: needinfo?(j.parkouss)
Resolution: WORKSFORME → ---
Attached file use profile dir
Fixed, along with small others things.
Assignee: nobody → j.parkouss
Status: REOPENED → ASSIGNED
Attachment #8705980 - Flags: review?(wlachance)
Attachment #8705980 - Flags: review?(wlachance) → review+
You need to log in before you can comment on or make changes to this bug.