1233819 - WebGL doesn't work on XP

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

The regression window for this change is:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=a4ce197dfecef223c0e9f84ab3bc1fc27c5cf0cb&tochange=bf864106469cefbea0cb1f9931d35a9b23350c73

Which suggests bug 1209612

Comment 1

[Jeff Muizelaar [:jrmuizel]]

[Tracking Requested - why for this release]: WebGL stopped working

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

Jeff if this was caused by the fix in bug 1209612 can you have a look? Thanks. 

Tracking since this seems to be a recent regression.

Comment 3

[Kelsey Gilbert [:jgilbert]]

I don't have a WinXP machine. Can you debug this :jrmuizel?

Comment 4

[Jeff Muizelaar [:jrmuizel]]

This broke because we no longer call GetAndInitDisplay() on XP. We don't call GetAndInitDisplay(*this, LOCAL_EGL_D3D11_ELSE_D3D9_DISPLAY_ANGLE) because gfxPlatform::CanUseDirect3D11ANGLE() is false.
                 }

Comment 5

[Kelsey Gilbert [:jgilbert]]

Attachment: 0001-Try-non-d3d11-ANGLE-if-d3d11-fails.patch

Comment 6

[Kelsey Gilbert [:jgilbert]]

Attachment: 0002-Add-test.patch

Comment 7

[Kelsey Gilbert [:jgilbert]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=40bffd8bd672

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/46f66d456838

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/46f66d456838

Comment 10

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8705852 [details] [diff] [review]
0001-Try-non-d3d11-ANGLE-if-d3d11-fails.patch

Approval Request Comment
[Feature/regressing bug #]: bug 1209612
[User impact if declined]: No WebGL on WinXP
[Describe test coverage new/current, TreeHerder]: Test included.
[Risks and why]: Low, since we have a test, and the code path we're adding is fairly simple.
[String/UUID change made/needed]: none

Comment 11

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8705852 [details] [diff] [review]
0001-Try-non-d3d11-ANGLE-if-d3d11-fails.patch

Approval Request Comment
(See previous Aurora request comment)

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8705852 [details] [diff] [review]
0001-Try-non-d3d11-ANGLE-if-d3d11-fails.patch

We are supporting XP just like any other systems, taking it. Should be in 45 beta 2.

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/4c6c0d328e29