1233837 - support migration override in distribution.ini

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Shane Caraveo (:mixedpuppy)]

Attachment: migration override in distribution.ini

override.ini is being used in repack distributions to prevent migration for some partner builds.  The problem is our uninstaller does not know about the file, leaving it behind when firefox is uninstalled.  This *may* be desired in some enterprise environments or other distributions we are unaware of.  

Rather than depending on override.ini for partner builds, lets just add support for migration override to distribution.ini.

We'll need to uplift any patch as far as we possibly can to make an important timeline, at least to aurora if not beta.

Comment 1

[Robert Strong (they/them - no direct email)]

Comment on attachment 8700175 [details] [diff] [review]
migration override in distribution.ini

Looks fine and simple enough to me and shouldn't have any of the bad repercussions the other methods that have been suggested would.

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Please request uplift to beta if the patch applies cleanly. Ritu, n-i to you to make sure you see this.

Comment 4

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8700175 [details] [diff] [review]
migration override in distribution.ini

Lets get this onto nightly, let it simmer a few days, I can verify some repacks against that and request uplifts.

Comment 5

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tracked for FF44

Comment 6

[Carter Trout]

I want to set the right expectations with stakeholders -- does "Tracked" mean it's committed to 44? 

Thanks

Comment 7

[Benjamin Smedberg]

Comment on attachment 8700175 [details] [diff] [review]
migration override in distribution.ini

No, tracked doesn't imply a commitment.

Comment 8

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c377d46fd037

Comment 9

[Shane Caraveo (:mixedpuppy)]

https://hg.mozilla.org/integration/fx-team/rev/69b5cacf1cbbdb7f47dc775c17db96482d5123eb
Bug 1233837 support migration wizard override from distribution.ini, r=bsmedberg

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/69b5cacf1cbb

Comment 11

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8700175 [details] [diff] [review]
migration override in distribution.ini

Approval Request Comment
[Feature/regressing bug #]: override.ini support
[User impact if declined]: override.ini is left behind after uninstall on windows, failing MS requirements for partners.
[Describe test coverage new/current, TreeHerder]: manual testing, verified nightly build against existing partner repacks
[Risks and why]: code change is in xre_main, failure would likely prevent any startup 
[String/UUID change made/needed]: none

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8700175 [details] [diff] [review]
migration override in distribution.ini

This is needed to meet partner requirements, Beta44+, Aurora45+

Comment 13

[Shane Caraveo (:mixedpuppy)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7b49ae23866a

Comment 14

[Shane Caraveo (:mixedpuppy)]

https://hg.mozilla.org/releases/mozilla-beta/rev/f3a1659cd0ea
https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=f3a1659cd0ea

Comment 15

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Marking 44 and 45 fixed based on comment 13 and 14.

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/f3a1659cd0ea

Comment 17

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel	beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS				Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected