Closed Bug 1233880 Opened 9 years ago Closed 9 years ago

[JSMarionette] Allow passing options to client.helper.waitForElementToDisappear

Categories

(Testing Graveyard :: JSMarionette, defect)

Product:
Testing Graveyard
Component:
JSMarionette
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mikehenrty, Assigned: mikehenrty)

References

Details

(Whiteboard: [MJS][systemsfe])

Attachments

(1 file)

[gaia] mikehenrty:bug-1233880-wait-for-disappear-options > mozilla-b2g:master
46 bytes, text/x-github-pull-request
aus
: review+
Details | Review
We are seeing many tests fail because waitForElementToDisappear timesout "relatively" quickly at 20 seconds. Let's allow test writers to configure this by passing in an options object similar to the one used in client.waitFor.
Comment on attachment 8700227 [details] [review] [gaia] mikehenrty:bug-1233880-wait-for-disappear-options > mozilla-b2g:master Gareth, could you take a look at this one too?
Attachment #8700227 - Flags: review?(gaye)
Comment on attachment 8700227 [details] [review] [gaia] mikehenrty:bug-1233880-wait-for-disappear-options > mozilla-b2g:master Or Aus.
Attachment #8700227 - Flags: review?(aus)
Looking good man! Thanks for the flurry of patches! We'll take this as the bestest Holiday Gift the Firefox OS automation guys could've ever had! :)
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 8700227 [details] [review] [gaia] mikehenrty:bug-1233880-wait-for-disappear-options > mozilla-b2g:master Forgot to toggle the mighty flag.
Attachment #8700227 - Flags: review?(gaye)
Attachment #8700227 - Flags: review?(aus)
Attachment #8700227 - Flags: review+
Assignee: nobody → mhenretty
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: