1233887 - Convert to Promise.jsm in EventEmitter

Status: RESOLVED FIXED

(DevTools :: General, defect)

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1233887 - Convert to Promise.jsm in EventEmitter. r=ejpbruel

Review commit: https://reviewboard.mozilla.org/r/28633/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28633/

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1233888 - Convert to Promise.jsm in app validator. r=ochameau

Review commit: https://reviewboard.mozilla.org/r/28635/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28635/

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1233888 - Convert to Promise.jsm in app projects. r=ochameau

Review commit: https://reviewboard.mozilla.org/r/28637/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28637/

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 940537 - Convert to Promise.jsm in debugger UI. r=jlongster

Review commit: https://reviewboard.mozilla.org/r/28639/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28639/

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1233890 - Convert to Promise.jsm in RDP server. r=ejpbruel

Review commit: https://reviewboard.mozilla.org/r/28641/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28641/

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1233891 - Convert to Promise.jsm in RDP client. r=ejpbruel

Review commit: https://reviewboard.mozilla.org/r/28643/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28643/

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1233887 - Convert to Promise.jsm in EventEmitter. r=ejpbruel

Review commit: https://reviewboard.mozilla.org/r/28653/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28653/

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=54f36d12bf3a

Comment 9

[Eddy Bruel [:ejpbruel]]

Comment on attachment 8700241 [details]
MozReview Request: Bug 1233887 - Convert to Promise.jsm in EventEmitter. r=ejpbruel

https://reviewboard.mozilla.org/r/28653/#review25523

This patch only converts to Promise.jsm in the EventEmitter tests, right? If so, r+.

Comment 10

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Smaller try run looks green:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=44666aa8453b

And yes, it's just some tests.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/72b88db55c8b

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/72b88db55c8b

Comment 13

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel	beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS				Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected