Remove gstreamer support

RESOLVED FIXED in Firefox 46

Status

()

Core
Audio/Video: Playback
P1
normal
RESOLVED FIXED
2 years ago
26 days ago

People

(Reporter: jya, Assigned: jya)

Tracking

Trunk
mozilla46
Points:
---

Firefox Tracking Flags

(firefox43 wontfix, firefox44 affected, firefox45 affected, firefox46 fixed)

Details

Attachments

(4 attachments)

(Assignee)

Description

2 years ago
Let's get rid of it now that it's unused
(Assignee)

Comment 1

2 years ago
Created attachment 8700440 [details] [diff] [review]
P1. Remove GStreamer support.

It was now unused by default.
Attachment #8700440 - Flags: review?(ajones)
(Assignee)

Comment 2

2 years ago
Created attachment 8700441 [details] [diff] [review]
P2. Remove GStreamer check from configure.
Attachment #8700441 - Flags: review?(mh+mozilla)
(Assignee)

Comment 3

2 years ago
Created attachment 8700442 [details] [diff] [review]
P3. Remove dependencies on gstreamer packages.
Attachment #8700442 - Flags: review?(mh+mozilla)
(Assignee)

Comment 4

2 years ago
Created attachment 8700443 [details] [diff] [review]
P4. Remove gstreamer exception from valgrind config.

This is a reversal of commit b28d496da7bf48432cb3aac3d10e7a66a267421c
Attachment #8700443 - Flags: review?(n.nethercote)
(Assignee)

Updated

2 years ago
Assignee: nobody → jyavenard
Summary: Remove gstreamer suppoert → Remove gstreamer support
Attachment #8700443 - Flags: review?(n.nethercote) → review+
Attachment #8700440 - Flags: review?(ajones) → review+
status-firefox43: --- → wontfix
status-firefox44: --- → affected
status-firefox45: --- → affected
Priority: -- → P1
Attachment #8700442 - Flags: review?(mh+mozilla) → review+
Attachment #8700441 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 5

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cdae4a84bfa6

Comment 6

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca4f31abb4f4
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f00c6ec93e9
https://hg.mozilla.org/integration/mozilla-inbound/rev/e1dd3b46edf0
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e2494f0cd39

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ca4f31abb4f4
https://hg.mozilla.org/mozilla-central/rev/5f00c6ec93e9
https://hg.mozilla.org/mozilla-central/rev/e1dd3b46edf0
https://hg.mozilla.org/mozilla-central/rev/3e2494f0cd39
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox46: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46

Comment 8

2 years ago
Isn't this required for support of various HD codecs on linux, which are needed, for example for 4k video on youtube? I've been using my own firefox build with gstreamer and the x264 and VPX codec since about FF 37 if I remember correctly, because the built-in codec wasn't working ...

See https://forums.gentoo.org/viewtopic-t-1013448-start-0-postdays-0-postorder-asc-highlight-libvpx%2Bfirefox.html
(Assignee)

Comment 9

2 years ago
Gstreamer has never been compatible with MSE; only plain mp4.
YouTube has removed support for HD content without MSE in Firefox 41 unless you had MSE or Flash (and flash support was removed in 43).

So no, gstreamer wasn't required to support various HD codec with youtube, it has never supported HD streaming in youtube.

Comment 10

9 months ago
I wish this didn't happen, we've discovered this now and now this commit makes completely impossible for us to have any kind of usable video playback on embedded devices based on Freescale i.MX6. I would like to underline how gstreamer is important for embedded systems that are not android based, on those systems gstreamer is a de facto standard. So, please, revert this, and allow people to choose to use it when they need it.
(Assignee)

Comment 11

9 months ago
You should enable the OMX decoder instead...

Comment 12

9 months ago
OMX is not an option on i.MX6 + Linux (not android). So the only available option is gstreamer-imx. Just to be clear: I'm not a big gstreamer fan, but I'm fine with it just because it works on that hardware.
(Assignee)

Comment 13

9 months ago
OpenMax use isn't limited to Android.

Gstreamer won't come back, it's incompatible with html5.

Comment 14

9 months ago
OpenMax is not usable on Linux on i.MX6. And I think the same applies for other vendors such as TexasInstruments.
Gstreamer covers most of the use cases where <video> tag is involved so that's better than *nothing*.

If it may help this discussion I can spend some time to find official freescale documentation about OpenMAX support on not android i.MX systems.

Comment 15

9 months ago
by the way I would like to underline that i.MX6 is a big player on the embedded linux scene, and it is here to stay for a long time, it doesn't look like a good move to remove support to it.
(Assignee)

Comment 16

9 months ago
then get them to provide an OpenMax SDK.

Comment 17

9 months ago
They are not going to support OpenMX, and they will keep providing users a patched chromium that has been updated just few times. I would like to underline how this is a poor technical choice: gstreamer would be the easy and good way to support video acceleration and despite your statements MSE if fully feasible with some additional work.
If you take a look to this: https://github.com/Samsung/ChromiumGStreamerBackend you will see that MSE can be implemented using gstreamer.

Comment 18

8 months ago
More info 
https://bugs.webkit.org/show_bug.cgi?id=99065
https://bugs.webkit.org/show_bug.cgi?id=157314
You need to log in before you can comment on or make changes to this bug.