1234092 - Remove gstreamer support

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Jean-Yves Avenard [:jya]]

Let's get rid of it now that it's unused

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: P1. Remove GStreamer support.

It was now unused by default.

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: P2. Remove GStreamer check from configure.

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: P3. Remove dependencies on gstreamer packages.

Comment 4

[Jean-Yves Avenard [:jya]]

Attachment: P4. Remove gstreamer exception from valgrind config.

This is a reversal of commit b28d496da7bf48432cb3aac3d10e7a66a267421c

Comment 5

[Jean-Yves Avenard [:jya]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cdae4a84bfa6

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca4f31abb4f4
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f00c6ec93e9
https://hg.mozilla.org/integration/mozilla-inbound/rev/e1dd3b46edf0
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e2494f0cd39

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ca4f31abb4f4
https://hg.mozilla.org/mozilla-central/rev/5f00c6ec93e9
https://hg.mozilla.org/mozilla-central/rev/e1dd3b46edf0
https://hg.mozilla.org/mozilla-central/rev/3e2494f0cd39

Comment 8

[luciano]

Isn't this required for support of various HD codecs on linux, which are needed, for example for 4k video on youtube? I've been using my own firefox build with gstreamer and the x264 and VPX codec since about FF 37 if I remember correctly, because the built-in codec wasn't working ...

See https://forums.gentoo.org/viewtopic-t-1013448-start-0-postdays-0-postorder-asc-highlight-libvpx%2Bfirefox.html

Comment 9

[Jean-Yves Avenard [:jya]]

Gstreamer has never been compatible with MSE; only plain mp4.
YouTube has removed support for HD content without MSE in Firefox 41 unless you had MSE or Flash (and flash support was removed in 43).

So no, gstreamer wasn't required to support various HD codec with youtube, it has never supported HD streaming in youtube.

Comment 10

[Davide Bettio]

I wish this didn't happen, we've discovered this now and now this commit makes completely impossible for us to have any kind of usable video playback on embedded devices based on Freescale i.MX6. I would like to underline how gstreamer is important for embedded systems that are not android based, on those systems gstreamer is a de facto standard. So, please, revert this, and allow people to choose to use it when they need it.

Comment 11

[Jean-Yves Avenard [:jya]]

You should enable the OMX decoder instead...

Comment 12

[Davide Bettio]

OMX is not an option on i.MX6 + Linux (not android). So the only available option is gstreamer-imx. Just to be clear: I'm not a big gstreamer fan, but I'm fine with it just because it works on that hardware.

Comment 13

[Jean-Yves Avenard [:jya]]

OpenMax use isn't limited to Android.

Gstreamer won't come back, it's incompatible with html5.

Comment 14

[Davide Bettio]

OpenMax is not usable on Linux on i.MX6. And I think the same applies for other vendors such as TexasInstruments.
Gstreamer covers most of the use cases where <video> tag is involved so that's better than *nothing*.

If it may help this discussion I can spend some time to find official freescale documentation about OpenMAX support on not android i.MX systems.

Comment 15

[Davide Bettio]

by the way I would like to underline that i.MX6 is a big player on the embedded linux scene, and it is here to stay for a long time, it doesn't look like a good move to remove support to it.

Comment 16

[Jean-Yves Avenard [:jya]]

then get them to provide an OpenMax SDK.

Comment 17

[Davide Bettio]

They are not going to support OpenMX, and they will keep providing users a patched chromium that has been updated just few times. I would like to underline how this is a poor technical choice: gstreamer would be the easy and good way to support video acceleration and despite your statements MSE if fully feasible with some additional work.
If you take a look to this: https://github.com/Samsung/ChromiumGStreamerBackend you will see that MSE can be implemented using gstreamer.

Comment 18

[mirh]

More info 
https://bugs.webkit.org/show_bug.cgi?id=99065
https://bugs.webkit.org/show_bug.cgi?id=157314