Rework animation sorting to support script-generated animations

RESOLVED FIXED in Firefox 46

Status

()

Core
DOM: Animation
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: birtles, Assigned: birtles)

Tracking

Trunk
mozilla46
Points:
---

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

This involves:

* Reworking CSSAnimation::HasLowerCompositeOrderThan to support generic animations[1]
* Reworking Animation::HasLowerCompositeOrderThan to handle the case when aOther provides some other sort of prioritization.

[1] https://dxr.mozilla.org/mozilla-central/rev/388bdc46ba51ee31da8b8abe977e0ca38d117434/layout/style/nsAnimationManager.cpp#134
Created attachment 8707259 [details] [diff] [review]
Rework sorting to handle to script-generated animations

Here's an initial attempt at this. I don't really like that Animation needs knowledge of CSSTransition and CSSAnimation, but I think it's better than the previous arrangement at least.
Assignee: nobody → bbirtles
Status: NEW → ASSIGNED
Created attachment 8707333 [details] [diff] [review]
Rework sorting to handle to script-generated animations
Attachment #8707259 - Attachment is obsolete: true
Comment on attachment 8707333 [details] [diff] [review]
Rework sorting to handle to script-generated animations

Thanks for all the reviews lately. I'll try to make this the last one for this week!
Attachment #8707333 - Flags: review?(cam)
Attachment #8707333 - Flags: review?(cam) → review+

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ce9161cb9392
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox46: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.