1234095 - Rework animation sorting to support script-generated animations

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect)

Description

[Brian Birtles (:birtles)]

This involves:

* Reworking CSSAnimation::HasLowerCompositeOrderThan to support generic animations[1]
* Reworking Animation::HasLowerCompositeOrderThan to handle the case when aOther provides some other sort of prioritization.

[1] https://dxr.mozilla.org/mozilla-central/rev/388bdc46ba51ee31da8b8abe977e0ca38d117434/layout/style/nsAnimationManager.cpp#134

Comment 1

[Brian Birtles (:birtles)]

Attachment: Rework sorting to handle to script-generated animations

Here's an initial attempt at this. I don't really like that Animation needs knowledge of CSSTransition and CSSAnimation, but I think it's better than the previous arrangement at least.

Comment 2

[Brian Birtles (:birtles)]

Attachment: Rework sorting to handle to script-generated animations

Comment 3

[Brian Birtles (:birtles)]

Comment on attachment 8707333 [details] [diff] [review]
Rework sorting to handle to script-generated animations

Thanks for all the reviews lately. I'll try to make this the last one for this week!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ce9161cb9392

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ce9161cb9392