1234129 - [Message]Invalid recipient covers valid recipient.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::SMS, defect, P1)

Description

[Autumn.Qiu(Leave from Mozilla)]

Attachment: logcat_rec.txt

[1.Description]:
[Aries v2.5&master][Flame v2.5&master][Message]Create a new SMS, type two valid recipients and an invalid recipient, tap back button and select the draft, the invalid recipient still exists and covers the second valid recipient, tap back button and select it again, the second valid recipient disappears.
See attachment: logcat_rec.txt & Aries_master_rec.3gp
Found Time: 13:51

[2.Testing Steps]: 
1. Launch Message
2. Create a new SMS.
3. Type two valid recipients such as "11111" and "22222" and an invalid recipient such as "ppuy".
4. Tap back button.
5. Select the draft and observe.
6. Tap an Invalid recipient.
7. Tap back button.
8. Select the draft and observe again.

[3.Expected Result]: 
In step 5, the invalid recipient should be automatically removed.
In step 8, all of valid recipient should display normally.

[4.Actual Result]: 
In step 5, the invalid recipient still exists and covers the second valid recipient.
In step 8, the second valid recipient disappears.

[5.Reproduction build]: 
Aries KK master(Affected):
Build ID               20151219131630
Gaia Revision          d069027f9af6f835ef869f1f01b52339e5a3f423
Gaia Date              2015-12-18 08:50:41
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/388bdc46ba51ee31da8b8abe977e0ca38d117434
Gecko Version          46.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151219.123525
Firmware Date          Sat Dec 19 12:35:33 UTC 2015
Bootloader             s1

Flame master_512M(Affected):
Build ID               20151220150206
Gaia Revision          d069027f9af6f835ef869f1f01b52339e5a3f423
Gaia Date              2015-12-18 08:50:41
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/388bdc46ba51ee31da8b8abe977e0ca38d117434
Gecko Version          46.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151220.191933
Firmware Date          Sun Dec 20 19:19:45 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Aries KK v2.5(Affected):
Build ID               20151218184045
Gaia Revision          eeed1451e0e48b63abe3199e4d6906adc2a762d2
Gaia Date              2015-12-17 14:53:36
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/766600655dfb1b67c380b9da4f4b19acb505a858
Gecko Version          44.0
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151218.174305
Firmware Date          Fri Dec 18 17:43:13 UTC 2015
Bootloader             s1

Flame v2.5_512M(Affected):
Build ID               20151218180935
Gaia Revision          eeed1451e0e48b63abe3199e4d6906adc2a762d2
Gaia Date              2015-12-17 14:53:36
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/766600655dfb1b67c380b9da4f4b19acb505a858
Gecko Version          44.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151218.172320
Firmware Date          Fri Dec 18 17:23:30 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Flame v2.2_512M(Unaffected):
Build ID               20151217032501
Gaia Revision          885647d92208fb67574ced44004ab2f29d23cb45
Gaia Date              2015-10-07 13:05:24
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/2120b3e6f680
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151217.071802
Firmware Date          Thu Dec 17 07:18:13 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Occasionally Recurrence, 6/10

[7.TCID]: 
Free test

Comment 1

[Autumn.Qiu(Leave from Mozilla)]

Attachment: Aries_master_rec.3gp

Comment 2

[Isabel Rios[:isabel_rios]]

[Blocking Requested - why for this release]: To discuss in the triage

Comment 3

[Julien Wajsberg [:julienw] (PTO -> Jan 5)]

See also bug 1015194, with a WIP that's feedback+ already :)

Comment 4

[Autumn.Qiu(Leave from Mozilla)]

The oldest build in b2g-inbound / mozilla-inbound is 20151021103123 / 20151021095459, which is later than the first broken build & last working build, so I try to do the regression in Nightly builds. 

Nightly Regression Window:
Build ID               20150929150202
Gaia Revision          f345f6a015709beeb2ca3955cab077fcaa959d3b
Gaia Date              2015-09-29 03:53:51
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/ccee6614fd9d18a31f263fbcfe9676b224d851aa
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150929.201052
Firmware Date          Tue Sep 29 20:11:01 EDT 2015
Firmware Version        V18D V4
Bootloader             L1TC000118D0

First Broken Environmental Variables:
Build ID               20151001030229
Gaia Revision          bd8ff00faac97ad6a2df5a6217910b8d295d56a3
Gaia Date              2015-10-01 06:59:53
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/096c0f407f8ba3ef7cfe4e0b831761993cac38b1
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151001.065013
Firmware Date          Thu Oct  1 06:50:25 EDT 2015
Firmware Version        V18D V4
Bootloader             L1TC000118D0

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/f345f6a015709beeb2ca3955cab077fcaa959d3b...bd8ff00faac97ad6a2df5a6217910b8d295d56a3

Hope this information helps.

Comment 5

[Steve Chung [:steveck]]

(In reply to Julien Wajsberg [:julienw] (PTO -> 2016) from comment #3)
> See also bug 1015194, with a WIP that's feedback+ already :)

Ah, thanks for the reminder. I knew we already have bug 1015194 for a long time but this issue is only regressed from 2.5. I didn't look inside the problem yet, maybe they are different root case and your patch could solve it all at once :) Unassign myself and we can revisit after bug 1015194 landed.

Comment 6

[Julien Wajsberg [:julienw] (PTO -> Jan 5)]

You can also steal the patch from bug 1015194 ;) But you're also right that this bug is maybe another regression, looks like bug 1205874 and bug 1176976 are in the regression window.

Comment 7

[Julien Wajsberg [:julienw] (PTO -> Jan 5)]

I realize we shouldn't save invalid recipients to a draft (for now). The issue is maybe that the validation logic is asynchronous but we're not waiting for it. Before bug 1176976, because of the dialog, we were waiting for it.

You can try the difference between:
* type "aaa" in the recipient panel, press back.
and
* type "aaa" in the recipient panel, press somewhere else to "assimilate" the recipient, press back.

Comment 8

[Steve Chung [:steveck]]

Change to 2.6 since non-TV blockers won't be able to grant the permission for 2.5

Comment 9

[Julien Wajsberg [:julienw] (PTO -> Jan 5)]

Mass closing of Gaia::SMS bugs. End of an era :(

Comment 10

[Julien Wajsberg [:julienw] (PTO -> Jan 5)]

Mass closing of Gaia::SMS bugs. End of an era :(