1234130 - MSVC linker warning LNK4217: locally defined symbol Hunspell::Hunspell() imported in function mozHunspell::SetDictionary()

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Chris Peterson [:cpeterson]]

mozHunspell.obj : warning LNK4217: locally defined symbol ??0Hunspell@@QAE@PBD00@Z (public: __thiscall Hunspell::Hunspell(char const *,char const *,char const *)) imported in function "public: virtual enum nsresult __stdcall mozHunspell::SetDictionary(wchar_t const *)" (?SetDictionary@mozHunspell@@UAG?AW4nsresult@@PB_W@Z)
mozHunspell.obj : warning LNK4217: locally defined symbol ??1Hunspell@@QAE@XZ (public: __thiscall Hunspell::~Hunspell(void)) imported in function "protected: virtual __thiscall mozHunspell::~mozHunspell(void)" (??1mozHunspell@@MAE@XZ)
mozHunspell.obj : warning LNK4217: locally defined symbol ?spell@Hunspell@@QAEHPBDPAHPAPAD@Z (public: int __thiscall Hunspell::spell(char const *,int *,char * *)) imported in function "public: virtual enum nsresult __stdcall mozHunspell::Check(wchar_t const *,bool *)" (?Check@mozHunspell@@UAG?AW4nsresult@@PB_WPA_N@Z)
mozHunspell.obj : warning LNK4217: locally defined symbol ?suggest@Hunspell@@QAEHPAPAPADPBD@Z (public: int __thiscall Hunspell::suggest(char * * *,char const *)) imported in function "public: virtual enum nsresult __stdcall mozHunspell::Suggest(wchar_t const *,wchar_t * * *,unsigned int *)" (?Suggest@mozHunspell@@UAG?AW4nsresult@@PB_WPAPAPA_WPAI@Z)
mozHunspell.obj : warning LNK4217: locally defined symbol ?get_dic_encoding@Hunspell@@QAEPADXZ (public: char * __thiscall Hunspell::get_dic_encoding(void)) imported in function "public: virtual enum nsresult __stdcall mozHunspell::SetDictionary(wchar_t const *)" (?SetDictionary@mozHunspell@@UAG?AW4nsresult@@PB_W@Z)

Comment 1

[Jorg K (CEST = GMT+2)]

This was caused by bug 1200065.
https://hg.mozilla.org/releases/mozilla-aurora/rev/04b17a8de4ed

These warnings are a little annoying, so it would be good to fix the issue or shut up the warning.

I tried to make some sense if it but only found some very MS specific information:
https://msdn.microsoft.com/en-us/library/aa3se25k%28v=vs.120%29.aspx
http://stackoverflow.com/questions/6979491/how-to-delete-warnings-lnk4217-and-lnk4049

Comment 2

[Mike Hommey [:glandium]]

DEFINES['HUNSPELL_STATIC'] = True needs to be added to extensions/spellcheck/hunspell/glue/moz.build

Comment 3

[Mike Hommey [:glandium]]

Attachment: Fix MSVC LNK4217 warning in hunspell

Comment 4

[Jorg K (CEST = GMT+2)]

Great! Thank you so much.

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 8711944 [details] [diff] [review]
Fix MSVC LNK4217 warning in hunspell

Solves the problem for me.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a09bdadea91c

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a09bdadea91c