Closed Bug 1234189 Opened 9 years ago Closed 8 years ago

Intermittent sharedtest/test/unit/sticky_header_test.js | "after each" hook - TypeError: this.sinon is null (app://sharedtest.gaiamobile.org/test/unit

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.6 S4 - 1/1

People

(Reporter: cbook, Assigned: kats)

References

(
URL
)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

[gaia] staktrace:donetest > mozilla-b2g:master
46 bytes, text/x-github-pull-request
kgrandon
: review+
Details | Review 
11:56:03 INFO - TEST-UNEXPECTED-FAIL | sharedtest/test/unit/sticky_header_test.js | "after each" hook - TypeError: this.sinon is null (app://sharedtest.gaiamobile.org/test/unit/sticky_header_test.js?time=1450698962558:69) 

https://treeherder.mozilla.org/logviewer.html#?job_id=2930240&repo=mozilla-central
Seems like it started with 1209970
Blocks: 1209970
I can take a look.
Assignee: nobody → bugmail.mozilla
Most likely it's because the two tests at [1] both set the scrollable.scrollTop to 1280. The second test (the one that's failing) may be a no-op because the scrollTop is already 1280, in which case the scroll event won't fire. It probably fires at some later time, after |this.sinon| has been torn down, resulting in the error shown in the log.

[1] https://github.com/mozilla-b2g/gaia/blob/95991d6bf08c6bcd52a06b243952316a56f452b3/apps/sharedtest/test/unit/sticky_header_test.js#L133-L139
So I was wrong about setting scrollTop being a no-op, but right about the scroll event firing at some later time, after |this.sinon| has been torn down. Prior to bug 1209970 the scroll event would fire more promptly so the async nature of the test was masked. With the new code the scroll event can be delayed a bit more, and depending on how much it is delayed, the test shutdown happens before or after the scroll event. The test shutdown should be delayed using the |done| argument like the other tests in the suite do, so that the async test runs to completion first. Patch incoming.
Comment on attachment 8700770 [details] [review]
[gaia] staktrace:donetest > mozilla-b2g:master

Vivien is inactive in Bugzilla so pushing review to Kevin. Please feel free to redirect to somebody else.
Attachment #8700770 - Flags: review?(kevin+bugzilla)
Comment on attachment 8700770 [details] [review]
[gaia] staktrace:donetest > mozilla-b2g:master

Seems fine to me, thanks!
Attachment #8700770 - Flags: review?(kevin+bugzilla) → review+
Keywords: autoland
Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.
Are the sheriffs processing checkin-needed for gaia PRs? This orange seems to be getting hit a lot and it would be nice to get the PR merged.
Flags: needinfo?(philringnalda)
Flags: needinfo?(cbook)
No idea: I never bought into the idea that typing `hg push` or whatever the git equivalent is was a sheriff task, and I'm not a B2G contributor.
Flags: needinfo?(philringnalda) → needinfo?(wkocher)
done - https://github.com/mozilla-b2g/gaia/commit/232f98de644f541cfbedae81235f05240898bc50
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(wkocher)
Flags: needinfo?(cbook)
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.6 S4 - 1/1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: