1234205 - Synced tabs icon needs inverted variant for menuPanel

Status: VERIFIED FIXED

(Firefox :: Sync, defect, P3)

Description

[Tim Nguyen :ntim]

When the subview is opened, the icon should turn white.

Comment 1

[Chris Karlof [:ckarlof]]

Ryan, can you confirm this behavior? I don't see other icons in the toolbar turn white after they open a submenu.

Comment 2

[Tim Nguyen :ntim]

(In reply to Chris Karlof [:ckarlof] from comment #1)
> Ryan, can you confirm this behavior? I don't see other icons in the toolbar
> turn white after they open a submenu.

This is about buttons inside the menu-panel. In the menu-panel, if you open the history subview, you can see the history icon turns white.

Comment 3

[Ryan Feeley [:rfeeley]]

Attachment: inverted.png

Inverted Synced Tabs icon? A picture is worth a few comments in this case. Attached. I am pretty sure it is either Stephen or Bryan that have the finished assets for this icon. One of them can provide.

Comment 4

[Chris Karlof [:ckarlof]]

> This is about buttons inside the menu-panel. In the menu-panel, if you open the history subview, you can see the history icon turns white.

Indeed. I can reproduce in Nightly 20160119030232.

Comment 5

[bbell]

Attachment: MenuPanel.zip

Here are the assets you need for Mac, Windows and Linux.

Comment 6

[Mark Hammond (PTO; back Oct-3) [:markh] [:mhammond]]

Bryan,
  It looks like these need to be crushed or optimized, or whatever it is you do :) The files are all significantly bigger:

 browser/themes/linux/menuPanel.png           | Bin 18621 -> 25617 bytes
 browser/themes/linux/[e-mail]        | Bin 43286 -> 57179 bytes
 browser/themes/osx/menuPanel-yosemite.png    | Bin 24167 -> 37678 bytes
 browser/themes/osx/[e-mail] | Bin 57442 -> 84530 bytes
 browser/themes/osx/menuPanel.png             | Bin 32184 -> 50900 bytes
 browser/themes/osx/[e-mail]          | Bin 74263 -> 113265 bytes
 browser/themes/windows/menuPanel-aero.png    | Bin 35835 -> 53251 bytes
 browser/themes/windows/[e-mail] | Bin 95608 -> 130906 bytes
 browser/themes/windows/menuPanel.png         | Bin 18114 -> 25617 bytes
 browser/themes/windows/[e-mail]      | Bin 41158 -> 57179 bytes
 
and I don't think the increased sizes can be explained by just that extra inverted icon.

Comment 7

[Tim Nguyen :ntim]

Attachment: menupanel-optimised.zip

I've optimised them using kraken.io lossless optimiser.

Comment 8

[Mark Hammond (PTO; back Oct-3) [:markh] [:mhammond]]

Attachment: 0001-Bug-1234205-add-an-inverted-version-of-the-synced-ta.patch

Comment 9

[bbell]

(In reply to Tim Nguyen [:ntim] from comment #7)
> Created attachment 8721205 [details]
> menupanel-optimised.zip
> 
> I've optimised them using kraken.io lossless optimiser.

thanks

Comment 10

[:Gijs (he/him)]

Comment on attachment 8721821 [details] [diff] [review]
0001-Bug-1234205-add-an-inverted-version-of-the-synced-ta.patch

Review of attachment 8721821 [details] [diff] [review]:
-----------------------------------------------------------------

rubberstamping the images, I'm going to assume they work. The CSS looks great. Sorry for not spotting this in the initial patch. :-\

Comment 11

[Mark Hammond (PTO; back Oct-3) [:markh] [:mhammond]]

Thanks - the sheriffs will hopefully beat me to the checkins!

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/1eefe1efe183

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1eefe1efe183

Comment 14

[Vasilica Tamas, QA [:vtamas]]

I was able to reproduce this issue on Firefox 46.0a1 (2016-01-08) using Windows 10 64-bit.

Verified fixed on Firefox 47.0a1 (2016-02-28) under Windows 10 64-bit, Ubuntu 12.04 32-bit and Mac OS X 10.11. The Synced tabs icon is successfully turned to white when the synced panel is opened.