1234289 - antivirus should sleep longer between retry exceptions

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect)

Description

[Jordan Lund (:jlund)]

e.g. 

10:45:39     INFO - Downloading pub/firefox/candidates/38.5.1esr-candidates/build1/update/win32/hr/firefox-38.5.0esr-38.5.1esr.partial.mar to cache/update/win32/hr/firefox-38.5.0esr-38.5.1esr.partial.mar
10:45:39    FATAL - Uncaught exception: Traceback (most recent call last):
10:45:39    FATAL -   File "/builds/slave/rel-m-esr38-av-000000000000000/scripts/mozharness/base/script.py", line 1693, in run
10:45:39    FATAL -     self.run_action(action)
10:45:39    FATAL -   File "/builds/slave/rel-m-esr38-av-000000000000000/scripts/mozharness/base/script.py", line 1635, in run_action
10:45:39    FATAL -     self._possibly_run_method(method_name, error_if_missing=True)
10:45:39    FATAL -   File "/builds/slave/rel-m-esr38-av-000000000000000/scripts/mozharness/base/script.py", line 1576, in _possibly_run_method
10:45:39    FATAL -     return getattr(self, method_name)()
10:45:39    FATAL -   File "scripts/scripts/release/antivirus.py", line 177, in get_files
10:45:39    FATAL -     pool.map(worker, find_release_files())
10:45:39    FATAL -   File "/tools/python27/lib/python2.7/multiprocessing/pool.py", line 227, in map
10:45:39    FATAL -     return self.map_async(func, iterable, chunksize).get()
10:45:39    FATAL -   File "/tools/python27/lib/python2.7/multiprocessing/pool.py", line 528, in get
10:45:39    FATAL -     raise self._value
10:45:39    FATAL - IncompleteRead: IncompleteRead(0 bytes read, 5709261 more expected)
10:45:39    FATAL - Running post_fatal callback...

Comment 1

[Jordan Lund (:jlund)]

turns out IncompleteRead is a subclass of HTTPException so antivirus does retry: https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/scripts/release/antivirus.py#160

Comment 2

[Jordan Lund (:jlund)]

Attachment: 151221_bug_1234289_antivirus.patch

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9a391c10014f

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9a391c10014f

Comment 5

[Jordan Lund (:jlund)]

needs uplift to beta

Comment 6

[Jordan Lund (:jlund)]

maybe we should just uplift to esr as this seems pretty harmless

Comment 7

[Jordan Lund (:jlund)]

uplifted all the way to esr38

Comment 8

[Mihai Tabara [:mtabara]⌚️GMT]

I think we can close this - I've followed up with a comment on bug 1248299.