Closed Bug 1234310 Opened 4 years ago Closed 4 years ago
.https .html for e10s
Now that bug 1233845 landed, the test doesn't need to be disabled any more since it doesn't crash.
Does this test pass the try server given that bug 1233245 hasn't landed yet?
Also I was going to enable it in bug 1219469 anyway. This will just make me rebase once more. ;-)
Comment on attachment 8700733 [details] [diff] [review] Enable navigation-redirect.https.html for e10s I was wrong before. This time I read the patch!
Attachment #8700733 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/93c07c3aeab9caa629df7039e07779632c97581b Bug 1234310 - Enable navigation-redirect.https.html for e10s. r=ehsan
Comment on attachment 8700733 [details] [diff] [review] Enable navigation-redirect.https.html for e10s Approval Request Comment [Feature/regressing bug #]: 1137287 [User impact if declined]: Missing test coverage for bug 1233845 [Describe test coverage new/current, TreeHerder]: This is enabling a test for bug 1233845's uplift. [Risks and why]: None. [String/UUID change made/needed]: None.
Comment on attachment 8700733 [details] [diff] [review] Enable navigation-redirect.https.html for e10s More tests is good! FYI, you don't need to request for an uplift for test only change.
This doesn't seem to apply to beta. Can we get a rebased patch if it needs to go to 44?
Looks like bug 1200677 needs to be uplifted.
Specifically, it introduces the test that is modified here. I believe test-only things don't need approval, so can it just be uplifted along with this patch?
You need to log in before you can comment on or make changes to this bug.