Closed
Bug 1234310
Opened 8 years ago
Closed 8 years ago
Enable navigation-redirect.https.html for e10s
Categories
(Core :: DOM: Service Workers, defect)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla46
People
(Reporter: jdm, Assigned: jdm)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.05 KB,
patch
|
ehsan.akhgari
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Now that bug 1233845 landed, the test doesn't need to be disabled any more since it doesn't crash.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8700733 -
Flags: review?(ehsan)
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → josh
Status: NEW → ASSIGNED
|
||
Comment 2•8 years ago
|
||
Does this test pass the try server given that bug 1233245 hasn't landed yet?
|
|
||
Comment 3•8 years ago
|
||
Also I was going to enable it in bug 1219469 anyway. This will just make me rebase once more. ;-)
|
||
Updated•8 years ago
|
Blocks: e10s-tests
tracking-e10s:
--- → +
|
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8700733 [details] [diff] [review] Enable navigation-redirect.https.html for e10s I was wrong before. This time I read the patch!
Attachment #8700733 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 5•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/93c07c3aeab9caa629df7039e07779632c97581b Bug 1234310 - Enable navigation-redirect.https.html for e10s. r=ehsan
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/93c07c3aeab9
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
|
|
Assignee | |
Comment 7•8 years ago
|
||
Comment on attachment 8700733 [details] [diff] [review] Enable navigation-redirect.https.html for e10s Approval Request Comment [Feature/regressing bug #]: 1137287 [User impact if declined]: Missing test coverage for bug 1233845 [Describe test coverage new/current, TreeHerder]: This is enabling a test for bug 1233845's uplift. [Risks and why]: None. [String/UUID change made/needed]: None.
Attachment #8700733 -
Flags: approval-mozilla-beta?
Attachment #8700733 -
Flags: approval-mozilla-aurora?
|
||
Updated•8 years ago
|
status-firefox44:
--- → affected
status-firefox45:
--- → affected
|
|
||
Comment 8•8 years ago
|
||
Comment on attachment 8700733 [details] [diff] [review] Enable navigation-redirect.https.html for e10s More tests is good! FYI, you don't need to request for an uplift for test only change.
Attachment #8700733 -
Flags: approval-mozilla-beta?
Attachment #8700733 -
Flags: approval-mozilla-beta+
Attachment #8700733 -
Flags: approval-mozilla-aurora?
Attachment #8700733 -
Flags: approval-mozilla-aurora+
|
||
Comment 9•8 years ago
|
||
| bugherder uplift | ||
https://hg.mozilla.org/releases/mozilla-aurora/rev/e7c4e76db4d1
This doesn't seem to apply to beta. Can we get a rebased patch if it needs to go to 44?
Flags: needinfo?(josh)
|
|
Assignee | |
Comment 11•8 years ago
|
||
Looks like bug 1200677 needs to be uplifted.
Flags: needinfo?(josh)
|
|
Assignee | |
Comment 12•8 years ago
|
||
Specifically, it introduces the test that is modified here. I believe test-only things don't need approval, so can it just be uplifted along with this patch?
Flags: needinfo?(wkocher)
|
|
||
Comment 13•8 years ago
|
||
| bugherder uplift | ||
https://hg.mozilla.org/releases/mozilla-beta/rev/b86b3deb9b01
Flags: needinfo?(wkocher)
|
|
||
Comment 14•8 years ago
|
||
| bugherder uplift | ||
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/b86b3deb9b01
status-b2g-v2.5:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•