Remove shortcut to add an item to your reading list from long tapping on reader view icon

RESOLVED FIXED in Firefox 46

Status

()

Firefox for Android
Reading List
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Margaret, Assigned: Margaret)

Tracking

(Blocks: 1 bug)

35 Branch
Firefox 46
Points:
---

Firefox Tracking Flags

(firefox46 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
I wrote a patch for this, but looking at UI telemetry, it seems like people do use this feature (see the "pageaction" method):
https://www.dropbox.com/s/s6njtfeh96xl99o/Screenshot%202016-01-18%2018.25.19.PNG?dl=0

That being said, this is still an order of magnitude smaller than the add to reading list button in the menu, and this feature is not very discoverable. It will also be even less discoverable when we remove the reading list panel and don't have that outdated "tip" in there.

What do you think? Should we still go ahead and get rid of this?
Flags: needinfo?(bbermes)
Flags: needinfo?(alam)
(Assignee)

Comment 2

2 years ago
Created attachment 8709198 [details]
MozReview Request: Bug 1234335 - Remove shortcut to add an item to your reading list from long tapping on reader view icon. r=ahunt

Review commit: https://reviewboard.mozilla.org/r/31327/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31327/
In an effort to migrate RL and cleaning up the UX around this whole feature - I'm in favor of this reset. 

I think it will help to decouple this button's association with both the "Reading List" and the "Reader View". This way, it will just always be about the Reader View.
Flags: needinfo?(alam)
(In reply to Anthony Lam (:antlam) from comment #3)
> In an effort to migrate RL and cleaning up the UX around this whole feature
> - I'm in favor of this reset. 
> 
> I think it will help to decouple this button's association with both the
> "Reading List" and the "Reader View". This way, it will just always be about
> the Reader View.

One conversation we have not yet had is: Do we keep the concept of a "Reading List" and therefore keep special UI (buttons and menus) that make adding to the reading list easier. By "easier" I mean: Goes straight to the Reading List folder, opens in reader view, and is offline.

I worry that we will make Bookmarks "harder" to add if we cause people to decide things like readable & offline when they "star" a URL.
(Assignee)

Comment 5

2 years ago
(In reply to Mark Finkle (:mfinkle) from comment #4)
> (In reply to Anthony Lam (:antlam) from comment #3)
> > In an effort to migrate RL and cleaning up the UX around this whole feature
> > - I'm in favor of this reset. 
> > 
> > I think it will help to decouple this button's association with both the
> > "Reading List" and the "Reader View". This way, it will just always be about
> > the Reader View.
> 
> One conversation we have not yet had is: Do we keep the concept of a
> "Reading List" and therefore keep special UI (buttons and menus) that make
> adding to the reading list easier. By "easier" I mean: Goes straight to the
> Reading List folder, opens in reader view, and is offline.
> 
> I worry that we will make Bookmarks "harder" to add if we cause people to
> decide things like readable & offline when they "star" a URL.

I started looking into removing the reading list button in reader view as well (bug 1226238), and looking into the code raised some other questions for me as well... if we want to support saving reader view items for offline use, maybe the first thing we should focus on removing is actually the reading list button in the menu, since that's what currently allows people to save non-reader-view articles, and what's gotten us into this confusing situation in the first place.

I'm tempted to say we should just go back to the way the reading list/reader view originally were, and make it so that your reading list is just a collection of reader view pages.

It feels like we keep trying to force this idea of a separation between reader view and reading list, but the fact that people keep getting confused about that indicates that maybe they really are just related.

That being said, maybe we should still remove this long-tap functionality for its lack of discoverability, but we should make sure people know how to save and retrieve these special offline versions of pages.
(Assignee)

Comment 6

2 years ago
(In reply to :Margaret Leibovic from comment #5)

> That being said, maybe we should still remove this long-tap functionality
> for its lack of discoverability, but we should make sure people know how to
> save and retrieve these special offline versions of pages.

I just remembered that we changed the reader view button logic, so that when it appears, it doesn't necessarily mean the page is reader-view-able. Given this information, I think we should still get rid of this long tap functionality, and only let users save things to the reading list when they're actually in reader view (whether that's through some menu button, UI in reader view itself, whatever).
Yes, get rid off the long-tap.

Adding Anthony as NI again in regards to comment #4 for confirming mocks. I know we've been going back and forth on that but I think Anthony found a good solution for that.
Flags: needinfo?(bbermes)
(Assignee)

Comment 8

2 years ago
(In reply to Mark Finkle (:mfinkle) from comment #4)
> (In reply to Anthony Lam (:antlam) from comment #3)
> > In an effort to migrate RL and cleaning up the UX around this whole feature
> > - I'm in favor of this reset. 
> > 
> > I think it will help to decouple this button's association with both the
> > "Reading List" and the "Reader View". This way, it will just always be about
> > the Reader View.
> 
> One conversation we have not yet had is: Do we keep the concept of a
> "Reading List" and therefore keep special UI (buttons and menus) that make
> adding to the reading list easier. By "easier" I mean: Goes straight to the
> Reading List folder, opens in reader view, and is offline.
> 
> I worry that we will make Bookmarks "harder" to add if we cause people to
> decide things like readable & offline when they "star" a URL.

Right now adding something to the "Reading List" does not necessarily make if readable & offline, so I don't know that people assume that right now about the functionality. Of course, we could go back to requiring you to save reader view items to your reading list to make this the case, but the key here is really the reader view aspect.

To save a "readable" page, you should be able to just save the reader view page you're looking at. And we can make a promise that we can keep that available for you offline, since we already have the parsed content in that case.

I talked about this with Barbara and Anthony yesterday, and we're in agreement that we should remove the "Reading List" concept from the browser as it currently exists, and instead let you save reader view pages.

We can talk about making an automatic folder in the future that shows you only your saved "about:reader" URLs, if we want to give users an easy way to get at all their saved reader view pages.
(Assignee)

Comment 9

2 years ago
Comment on attachment 8709198 [details]
MozReview Request: Bug 1234335 - Remove shortcut to add an item to your reading list from long tapping on reader view icon. r=ahunt

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31327/diff/1-2/
Attachment #8709198 - Attachment description: MozReview Request: Bug 1234335 - Remove shortcut to add an item to your reading list from long tapping on reader view icon → MozReview Request: Bug 1234335 - Remove shortcut to add an item to your reading list from long tapping on reader view icon. r=ahunt
Attachment #8709198 - Flags: review?(ahunt)

Updated

2 years ago
Attachment #8709198 - Flags: review?(ahunt) → review+

Comment 10

2 years ago
Comment on attachment 8709198 [details]
MozReview Request: Bug 1234335 - Remove shortcut to add an item to your reading list from long tapping on reader view icon. r=ahunt

https://reviewboard.mozilla.org/r/31327/#review28519

Works, and looks good to me!
(Assignee)

Comment 11

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/3cd42a5570c5f4af767d3aece0fbcdef1be66e31
Bug 1234335 - Remove shortcut to add an item to your reading list from long tapping on reader view icon. r=ahunt
(Assignee)

Comment 12

2 years ago
I was going to hold off on landing this until 47 with the rest of the reading list migration changes, but our UI telemetry tells us this is used way so much less than the add to reading list button in the menu, so I don't think it's worth waiting.

Comment 13

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3cd42a5570c5
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Long tapping on the reader view icon, won't add the page to reading list, so:
Verified as fixed using:
Device: Nexus 6 (Android 6.0)
Build: Firefox for Android 46.0a1 (2015-01-24)
status-firefox46: fixed → verified
You need to log in before you can comment on or make changes to this bug.