Closed
Bug 1234385
Opened 10 years ago
Closed 9 years ago
In code support for driverVersionMax from downloadable blocklist
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla46
People
(Reporter: milan, Assigned: milan)
Details
(Keywords: feature)
Attachments
(1 file)
9.91 KB,
patch
|
BenWa
:
review+
ritu
:
approval-mozilla-aurora+
ritu
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
We support driverVersionMax when in code, but not when in downloadable blocklist. One aspect of this is covered here: https://github.com/mozilla/olympia/issues/1123, but we also need the parsing.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → milan
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8701115 -
Flags: review?(bgirard)
Updated•10 years ago
|
Attachment #8701115 -
Flags: review?(bgirard) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Keywords: checkin-needed
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8701115 [details] [diff] [review]
Recognize driverVersionMax when parsing downloadable blocklist. r=benwa
Approval Request Comment
[Feature/regressing bug #]:n/a/, new functionality
This is a minor change (most of the changes are in the tests) to allow us to recognize a range of driver versions when using the downloadable blocklist. We already had this functionality when blocklisting in the code, but were missing the parsing of one parameter to let us specify the high end of the range.
Attachment #8701115 -
Flags: approval-mozilla-beta?
Attachment #8701115 -
Flags: approval-mozilla-aurora?
Comment on attachment 8701115 [details] [diff] [review]
Recognize driverVersionMax when parsing downloadable blocklist. r=benwa
Patch has automated tests which is good. We also need this fix to improve our stability, Beta44+, Aurora45+
Attachment #8701115 -
Flags: approval-mozilla-beta?
Attachment #8701115 -
Flags: approval-mozilla-beta+
Attachment #8701115 -
Flags: approval-mozilla-aurora?
Attachment #8701115 -
Flags: approval-mozilla-aurora+
status-firefox44:
--- → affected
status-firefox45:
--- → affected
Keywords: checkin-needed
Comment 6•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Comment 7•9 years ago
|
||
bugherder uplift |
Comment 8•9 years ago
|
||
bugherder uplift |
Comment 9•9 years ago
|
||
bugherder uplift |
status-b2g-v2.5:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•