1234417 - CreateECPublicKey leaks a reference to the internal PKCS#11 slot

Status: RESOLVED FIXED

(Core :: Security, defect)

Description

[Dana Keeler (she/her) [:keeler]]

CreateECPublicKey creates a SECKEYPublicKey allocated on a scoped arena. It then calls CryptoKey::PublicKeyValid, which has the side-effect of importing the key to the internal PKCS#11 slot. When the arena goes out of scope, the memory for the key is released, but the reference to the slot isn't, causing a leak.

(This can be reproduced by running `NSPR_LOG_MODULES=pipnss:5 ./mach xpcshell-test dom/push/test/xpcshell/test_notification_data.js` and observing the string "NSS SHUTDOWN FAILURE" in the output.)

Comment 1

[Dana Keeler (she/her) [:keeler]]

Attachment: MozReview Request: bug 1234417 - fix a leak in CreateECPublicKey r?rbarnes

Review commit: https://reviewboard.mozilla.org/r/28905/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28905/

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8701142 [details]
MozReview Request: bug 1234417 - fix a leak in CreateECPublicKey r?rbarnes

LGTM. I wrote it but I think I can't give r+.

Comment 3

[Richard Barnes [:rbarnes]]

Comment on attachment 8701142 [details]
MozReview Request: bug 1234417 - fix a leak in CreateECPublicKey r?rbarnes

https://reviewboard.mozilla.org/r/28905/#review25887

LGTM.  Thanks for the catch, Keeler!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f745c6e024a3

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f745c6e024a3