1234540 - [Static Analysis][Dereference null return value] In function nsCacheEntryHashTable::AddEntry from nsCacheEntry.cpp

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity added that pointer hashEntry can be null thus having a null pointer dereference:

>>    hashEntry = table.Add(&(cacheEntry->mKey), fallible);
>>#ifndef DEBUG_dougt
>>    NS_ASSERTION(((nsCacheEntryHashTableEntry *)hashEntry)->cacheEntry == 0,
>>                 "### nsCacheEntryHashTable::AddEntry - entry already used");
>>#endif
>>    ((nsCacheEntryHashTableEntry *)hashEntry)->cacheEntry = cacheEntry;

This can happen if in function table->Add malloc fails because of oom:
>>    MOZ_RELEASE_ASSERT(SizeOfEntryStore(CapacityFromHashShift(), mEntrySize,
>>                                        &nbytes));
>>    mEntryStore.Set((char*)malloc(nbytes));
>>    if (!mEntryStore.Get()) {
>>      return nullptr;
>>    }

Comment 1

[Andi [:andi]]

Attachment: Bug 1234540.diff

Comment 2

[Andi [:andi]]

Attachment: Bug 1234540.diff

Comment 3

[Patrick McManus [:mcmanus]]

please check in the reviewed patch or otherwise resolve this bug. thanks

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d0459ee243da

Comment 5

[Andi [:andi]]

it's been pushed to inbound.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d0459ee243da