123457 - Thread safety assertions when quitting the app after using imap

Status: VERIFIED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Scott MacGregor]

For a while now, every time you quit the app after using imap, you get a bunch
of thread safety assertions. This is because we are releasing webshell on the
wrong thread (on the imap socket thread to be precise). The webshell holds on to
many objects which are not thread safe. Hence all the alerts. 

The problem is when we clear out the notification callbacks on our socket
transport, the transport releases the last reference to the callback (which is
the webshell), causing all of these assertions.

Comment 1

[Scott MacGregor]

accepting

Comment 2

[Scott MacGregor]

Attachment: the fix

My fix involves setting the notification callback on the transport EVERY time
we run a url instead of when we first create the socket. In addition, when we
finish running a url, we clear the notification callbacks object on the socket.
So the time between running urls, the socket no longer has a notification
callback. 

As a result of this change, the notification callback is always getting
released when the mock channel goes away and it always released on the UI
thread. i.e the socket thread is now no longer the last owner.

Comment 3

[David :Bienvenu]

Comment on attachment 67836 [details] [diff] [review]
the fix

r=bienvenu - do we still hold onto the url for displaying a message until the
next time we load a message?

Comment 4

[Scott MacGregor]

fixed.

Comment 5

[David :Bienvenu]

*** Bug 109815 has been marked as a duplicate of this bug. ***

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

I don't see these with a trunk Win2k debug build.

Verified.