Closed
Bug 1234644
Opened 8 years ago
Closed 8 years ago
[css-grid] Investigate "24 bytes leaked (nsTArray_base)" when running reftest grid-repeat-auto-fill-fit-006.html
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
References
Details
(Keywords: memory-leak, regression)
Attachments
(1 file, 1 obsolete file)
5.21 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
I'm guessing it's the window.getComputedStyle(elem).gridTemplateColumns that triggers it.
Assignee | ||
Comment 1•8 years ago
|
||
It looks like this leak is for real - it also showed up on 10.10 and XP debug reftests on m-i. I missed them in my Try run since those platforms are excluded by default for reftests. So grid-repeat-auto-fill-fit-006.html is disabled for now: https://hg.mozilla.org/integration/mozilla-inbound/rev/b6c9b8523293
Assignee | ||
Comment 2•8 years ago
|
||
I think the leak is fixed already by bug 1234707. It might be worth taking this patch anyway since it'll avoid the unnecessary allocation when we return early. FTR: we leaked the |valueList| value when returning early (with a 'none' value) inside the "if (aTrackSizes)" branch.
Assignee: nobody → mats
Attachment #8703305 -
Flags: review?(dholbert)
Assignee | ||
Updated•8 years ago
|
Blocks: 1118820
Keywords: regression
Assignee | ||
Comment 3•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=11acbb24d3d2
Assignee | ||
Comment 4•8 years ago
|
||
Minor correction to one of the MOZ_ASSERTs.
Attachment #8703305 -
Attachment is obsolete: true
Attachment #8703305 -
Flags: review?(dholbert)
Attachment #8703391 -
Flags: review?(dholbert)
Updated•8 years ago
|
Attachment #8703391 -
Flags: review?(dholbert) → review+
Assignee | ||
Updated•8 years ago
|
Flags: in-testsuite+
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/814ec51c8f03
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•