1234644 - [css-grid] Investigate "24 bytes leaked (nsTArray_base)" when running reftest grid-repeat-auto-fill-fit-006.html

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Mats Palmgren (inactive)]

I'm guessing it's the window.getComputedStyle(elem).gridTemplateColumns
that triggers it.

Comment 1

[Mats Palmgren (inactive)]

It looks like this leak is for real - it also showed up on 10.10 and XP debug reftests
on m-i.  I missed them in my Try run since those platforms are excluded by default
for reftests.

So grid-repeat-auto-fill-fit-006.html is disabled for now:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b6c9b8523293

Comment 2

[Mats Palmgren (inactive)]

Attachment: fix

I think the leak is fixed already by bug 1234707.  It might be worth taking this patch anyway since it'll avoid the unnecessary allocation when we return early.

FTR: we leaked the |valueList| value when returning early (with a 'none' value)
inside the "if (aTrackSizes)" branch.

Comment 3

[Mats Palmgren (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=11acbb24d3d2

Comment 4

[Mats Palmgren (inactive)]

Attachment: fix

Minor correction to one of the MOZ_ASSERTs.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/814ec51c8f03

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/814ec51c8f03