Closed Bug 1234659 Opened 9 years ago Closed 9 years ago

Intermittent test_bug332655-2.html | deleting and inserting RTL char at beginning of line shouldn't change: expected data:image/png;base64,[...]

Categories

(Core :: Widget: Gtk, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox45 --- fixed
firefox46 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

Details

(Keywords: intermittent-failure)

Attachments

(6 files)

Spinning this off of bug 1221919 (which covers a test_bug582181-1.html intermittent), to cover intermittents in related test test_bug582181-2.html. Sample failure: { 01:40:58 INFO - 264 INFO TEST-UNEXPECTED-FAIL | layout/base/tests/test_bug332655-2.html | deleting and inserting RTL char at beginning of line shouldn't change: expected data:image/png;base64,[...] 01:40:59 INFO - 265 INFO TEST-UNEXPECTED-FAIL | layout/base/tests/test_bug332655-2.html | the order entering Bidi text shouldn't change rendering: expected data:image/png;base64,[...] } https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-aurora&job_id=1624323 I'll attach a log-snippet textfile with full data URIs. The mismatching things here are <input> elements, and it looks like their backgrounds don't quite match (but it's very subtle).
Attached file gzipped full log
Attached image "expected" screenshot
Attached image "but got" screenshot
Here's a handmade test-failure log, suitable for viewing with reftest-analyzer.xhtml. The differences are all visually-imperceptible (to my eye) -- it's stuff like a background of rgb(245,245,245) vs rgb(255,255,255).
I expect "-moz-appearance: none" should help here, as it did in bug 1204897. I'll write a patch for that.
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
(In reply to Daniel Holbert [:dholbert] from comment #0) > Spinning this off of bug 1221919 (which covers a test_bug582181-1.html > intermittent), to cover intermittents in related test test_bug582181-2.html. Oops, looks like I misread the log -- there is no failure in test_bug582181-2.html in the log that I filed this bug about -- the failure is in test_bug332655-2.html. (different bug number in the filename) So this is less of a spin-off of bug 1221919 and is really much more closely related to bug 1204897 (it's the "-2.html" version of that bug's test). I'm going to land a version of the exact patch from bug 1204897 (just for this second test file) with assumed rs=jfkthame; no sense in spending review-time on a pretty much identical test-tweak. (jfkthame, hope this is fine by you.)
Attached patch workaround v1Splinter Review
(here's the patch I intend to land, fwiw. Trees are undergoing maintenance at the moment; I'll land this when they're accepting pushes again.)
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Thanks for the uplift, KWierso!
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: