Closed Bug 1234697 Opened 9 years ago Closed 9 years ago

Aurora/Beta Windows bc is perma-leaking with WARNING - TEST-UNEXPECTED-FAIL | leakcheck | default process: 84/128 bytes leaked (Mutex, nsBaseAppShell)

Categories

(Core :: Widget, defect)

Product:
Core
Component:
Widget
Version:
45 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1220517
Tracking Flags:
Tracking Status
firefox45 --- affected

People

(Reporter: KWierso, Unassigned)

References

Details

I'm not super confident that I know enough to write a patch to suppress these leaks myself. Any chance you could look into this since you wrote that other suppression patch?
Flags: needinfo?(continuation)
Or we could push backing out the patch from bug 1195295 on aurora to try, and see whether or not that's the reason it's now 100%. And then just suppress it and ignore it forever, because of course that's what we do with leaks, but think how much better we'd feel about ourselves if we knew exactly what caused the leak we ignored.
Depends on: 1220517
And if someone does that, you want WinXP or Win8 tests, where it actually is 100%, rather than Win7 where you'd have to trigger four or five times to be sure it was gone.
Flags: needinfo?(continuation)
(In reply to Phil Ringnalda (:philor) from comment #2) > Or we could push backing out the patch from bug 1195295 on aurora to try, > and see whether or not that's the reason it's now 100%. Yeah that's what I was planning to do. > And then just suppress it and ignore it forever, because of course that's > what we do with leaks, but think how much better we'd feel about ourselves > if we knew exactly what caused the leak we ignored. We don't suppress most leaks.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b6c7480e4920&filter-classifiedState=unclassified&selectedJob=14843089 - the Win7/Win8 green was so ridiculous I had to double-check that there wasn't a change in chunking moving browser/base/content/test/general/ out of bc7 for them.
That bug includes a number of patches, but only the last one is more than just test changes. just the last one reverted: https://treeherder.mozilla.org/#/jobs?repo=try&revision=557502e5b88a all reverted: https://treeherder.mozilla.org/#/jobs?repo=try&revision=84ced9118812
You need bc7 - aurora runs Win debug bc in three chunks, with the leak in bc1, but trunk and thus try runs it in seven chunks, which puts the leaking directory into bc7.
(In reply to Phil Ringnalda (:philor) from comment #7) > You need bc7 - aurora runs Win debug bc in three chunks, with the leak in > bc1, but trunk and thus try runs it in seven chunks, which puts the leaking > directory into bc7. Alright, thanks. I've retriggered those tests. I backed the patch out from inbound already so maybe I'll have to reland it...
Summary: Aurora Windows bc1 is perma-leaking with WARNING - TEST-UNEXPECTED-FAIL | leakcheck | default process: 84/128 bytes leaked (Mutex, nsBaseAppShell) → Aurora/Beta Windows bc is perma-leaking with WARNING - TEST-UNEXPECTED-FAIL | leakcheck | default process: 84/128 bytes leaked (Mutex, nsBaseAppShell)
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: intermittent-failure
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.