Closed
Bug 1234699
Opened 9 years ago
Closed 9 years ago
Come up with a way to toggle tool icon set
Categories
(DevTools :: Framework, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: bgrins, Assigned: bgrins)
References
Details
Attachments
(1 file, 5 obsolete files)
|
6.40 KB,
patch
|
bgrins
:
review+
|
Details | Diff | Splinter Review |
We should have a way to toggle a custom icon set for the toolbox on top of an existing theme. I believe this should happen in theme-switching.js since that can happen per toolbox load and not a single time per-process as in definitions.js.
|
Assignee | |
Comment 1•9 years ago
|
||
Something like this would probably work without touching the definitions file. This also lets us reset the opacity to 1 and leave the settings cog's opacity alone. Just guessed on how to achieve the image swap using a border trick, there may be a better way to do that.
|
||
Comment 2•9 years ago
|
||
Check one of my themes on how to override icons of the devtools buttons:
Nautipolis, Walnut, LittleFox, etc.
p.s. that is why custom full themes are useful!
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8710041 [details] [diff] [review]
toggle-icons-idea.patch
ui-reviewed this Brian, looks good to me (other than the "XXX: Fix this conditional" comment you have for yourself in the code.
Attachment #8710041 -
Flags: ui-review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
rebased
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8723266 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 6•9 years ago
|
||
rebased
|
|
Assignee | |
Comment 7•9 years ago
|
||
Gabe please take a look at this when you have a chance
Assignee: nobody → bgrinstead
Attachment #8710041 -
Attachment is obsolete: true
Attachment #8723276 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8730348 -
Flags: review?(gl)
|
||
Updated•9 years ago
|
Attachment #8730348 -
Flags: review?(gl) → review+
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8730348 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 9•9 years ago
|
||
Missed the window on this, closing it out
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•