Closed Bug 1234700 Opened 8 years ago Closed 8 years ago

Hide window.showModalDialog, at least when e10s is enabled

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
e10s m8+ ---
firefox46 --- fixed

People

(Reporter: emk, Assigned: emk)

References

Details

(Keywords: dev-doc-complete, site-compat)

Attachments

(1 file)

The broken feature is worse than no feature because the former will hinder feature detection.
This is not a theoretical possibility. The broken showModalDialog breaks at least  Office 365 and Exchange 2013. See bug 1077002 comment #13 and onwards.
tracking-e10s: --- → ?
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #8701376 - Flags: review?(jmathies)
lgtm, fwiw
Attachment #8701376 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/mozilla-central/rev/1b9b9c8d4207
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
(In reply to Kohei Yoshino [:kohei] from comment #9)
> Posted the site compat doc:
> https://www.fxsitecompat.com/en-US/docs/2015/showmodaldialog-has-been-disabled-in-multi-process-firefox/

> showModalDialog has been disabled in multi-process Firefox

I think the term "disable" is obscure here. Prior to Firefox 39, showModalDialog always threw NS_ERROR_UNEXPECTED in e10s. Firefox 39 changed the logic to check e10s explicitly and throw NS_ERROR_NOT_AVAILABLE if in e10s. This bug removed showModalDialog itself from the window object, but showModalDialog was already "disabled" in e10s.

> At least Office 365 and Exchange 2016 are known to be broken due to the missing showModalDialog.

They are broken due to present-but-unworking showModalDialog. They will work if showModalDialog is missing because they use feature detection. This bug will *fix* them in e10s.
As this is not the default, I have added a comment in
https://developer.mozilla.org/en-US/Firefox/Releases/46#DOM_HTML_DOM
only
(In reply to Masatoshi Kimura [:emk] from comment #10)
> (In reply to Kohei Yoshino [:kohei] from comment #9)
> I think the term "disable" is obscure here. Prior to Firefox 39,
> showModalDialog always threw NS_ERROR_UNEXPECTED in e10s. Firefox 39 changed
> the logic to check e10s explicitly and throw NS_ERROR_NOT_AVAILABLE if in
> e10s. This bug removed showModalDialog itself from the window object, but
> showModalDialog was already "disabled" in e10s.

Thanks for your clarification. I'm adding the details to the doc. The title may be okay if explained well.
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.