WebMBufferedState::UpdateIndex reads entire file at once when playing a local file

NEW
Unassigned
(NeedInfo from)

Status

()

P3
normal
3 years ago
11 months ago

People

(Reporter: kinetik, Unassigned, NeedInfo)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(firefox46 affected)

Details

(Reporter)

Description

3 years ago
Added in bug 1148102. Called from http://mxr.mozilla.org/mozilla-central/source/dom/media/webm/WebMDemuxer.cpp#448 with a local file, the cached ranges will cover the entire file.

The old WebMReader generated the buffered ranges as data flowed into the MediaCache via NotifyDataArrived and included a special case for local files that reported the entire file as cached.  We're now reading and parsing every byte of the file for local files and building a complete WebMBufferedState, but doing this in one step when EnsureUpToDateIndex is called is inefficient and slow for large files and/or slow media.
The up side of this is it allows to seek into webm without cues as we were discussing in Orlando
Priority: -- → P2
Mass change P2 -> P3
Priority: P2 → P3

Comment 3

a year ago
Is this still needed/wanted?
Flags: needinfo?(kinetik)
Flags: needinfo?(jyavenard)
(Reporter)

Comment 4

11 months ago
The suboptimal behaviour is still present but if nobody is complaining it might not be worth the effort to fix.
Flags: needinfo?(kinetik)
You need to log in before you can comment on or make changes to this bug.