1234727 - WebMBufferedState::UpdateIndex reads entire file at once when playing a local file

Status: NEW

(Core :: Audio/Video: Playback, defect, P5)

Description

[Matthew Gregan [:kinetik]]

Added in bug 1148102. Called from http://mxr.mozilla.org/mozilla-central/source/dom/media/webm/WebMDemuxer.cpp#448 with a local file, the cached ranges will cover the entire file.

The old WebMReader generated the buffered ranges as data flowed into the MediaCache via NotifyDataArrived and included a special case for local files that reported the entire file as cached.  We're now reading and parsing every byte of the file for local files and building a complete WebMBufferedState, but doing this in one step when EnsureUpToDateIndex is called is inefficient and slow for large files and/or slow media.

Comment 1

[Jean-Yves Avenard [:jya]]

The up side of this is it allows to seek into webm without cues as we were discussing in Orlando

Comment 2

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Mass change P2 -> P3

Comment 3

[Florian Bender]

Is this still needed/wanted?

Comment 4

[Matthew Gregan [:kinetik]]

The suboptimal behaviour is still present but if nobody is complaining it might not be worth the effort to fix.

Comment 5

[Byron Campen [:bwc]]

Seems like there isn't much interest in this.