1234800 - Bug 1147673 inadvertently removed dirty rect adjustment of fixed-pos frames

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Markus Stange [:mstange]]

I only meant to remove the clip adjustment code, not the code that adjusts dirty rects.

Comment 1

[Markus Stange [:mstange]]

Attachment: attempted test

I tried to write a test for this, but this test passes even before I reinstate the dirty rect adjustment. (It only passes with --e10s --setpref layout.scroll.root-frame-containers=true .)

Comment 2

[Markus Stange [:mstange]]

Attachment: MozReview Request: Bug 1234800 - Move this line to the right place. r?tn

Review commit: https://reviewboard.mozilla.org/r/28961/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28961/

Comment 3

[Timothy Nikkel (:tnikkel)]

Comment on attachment 8701440 [details]
MozReview Request: Bug 1234800 - Move this line to the right place. r?tn

https://reviewboard.mozilla.org/r/28961/#review25749

Thanks!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e32159281b0c

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e32159281b0c

Comment 6

[Markus Stange [:mstange]]

https://reviewboard.mozilla.org/r/28961/#review26683

::: layout/base/nsDisplayList.cpp:750
(Diff revision 1)
>    nsRect dirty = dirtyRectRelativeToDirtyFrame - aFrame->GetOffsetTo(aDirtyFrame);

Welp, this line needs to move down under the if. As it stands, this patch is completely useless.

Comment 7

[Markus Stange [:mstange]]

Comment on attachment 8701440 [details]
MozReview Request: Bug 1234800 - Move this line to the right place. r?tn

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28961/diff/1-2/

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9edbc91c5b62

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9edbc91c5b62