1234825 - Add CI testing for tc-secrets

Status: RESOLVED FIXED

(Taskcluster :: Services, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

TC-Github doesn't seem to post its results back to the PR, or I'd use that.  So, maybe just adding some Travis support?

Ideally this comes along with tests that do not require an auth endpoint and credentials.

Comment 1

[Pete Moore [:pmoore][:pete]]

At the same time would be nice to auto-release from travis to npm on git tag, and add README.md badge for npm (to show latest released version), docs badge (if we auto-publish docs), travis status badge, and links to docs.taskcluster.net, tools.taskcluster.net etc.

At the same time we should set up a test coverage report (maybe coveralls) and a badge to link to coverage reports.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

tc-secrets is not deployed from npm, so I'm not sure we should release there at all, or have distinct semver versions.

Other than that, sounds good.

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

I'm looking at using nock to implement a fake https://auth.taskcluster.net/v1/authenticateHawk that authenticates out of a local, test-defined auth database.  This would eliminate the need to use real TC credentials for these unit tests.

Comment 4

[Pete Moore [:pmoore][:pete]]

(In reply to Dustin J. Mitchell [:dustin] from comment #2)
> tc-secrets is not deployed from npm, so I'm not sure we should release there
> at all, or have distinct semver versions.
> 
> Other than that, sounds good.

Quite right - apologies!

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

Let's start with
  https://github.com/taskcluster/taskcluster-secrets/pull/9

There's more to do here, not least adding a .travis.yml.  But if I can, I'd like to get to a point where there's no need for encrypted env vars for Travis to run.

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

For Azure table storage, we could add a fake at a few levels:

 - use nock to mock the Azure API
 - fake out fast-azure-storage
 - fake out azure-entities

I think the latter is the most practical: the semantics it exposes are fairly well-defined and easily reproduced, and we can even add some extra bits for more robustness against races (for example, every modify can fail the first time, and removes can optionally fail due to an intervening modification).

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

ah, that's bug 1215568

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

I landed the fakeauth module into taskcluster-lib-testing, but I didn't release a new version, because
 (a) Travis is showing failures with node 5 only
 (b) I don't have permission (https://www.npmjs.com/package/taskcluster-lib-testing)
 (c) I don't know if I should then ship a new taskcluster-base, or if taskcluster-base is frozen.
John, can you help me out here?

Comment 9

[Dustin J. Mitchell [:dustin] (he/him)]

I released a new version.  We just stopped testing on node 5.  I did not ship a new tc-base for this particular change -- my intent is to start apps using the tc-lib-* directly, rather than double-releasing everything.

Comment 10

[Dustin J. Mitchell [:dustin] (he/him)]

OK, tests for tc-secrets now pass with or without credentials.

Comment 11

[Pete Moore [:pmoore][:pete]]

I enabled taskcluster-secrets on travis now - the .travis.yml file had been created, but the repository wasn't enabled on travis. We haven't had any builds on master yet though.