1234955 - Make TEST_DIRS a SPECIAL_VARIABLE

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Make TEST_DIRS a SPECIAL_VARIABLE

Using TEST_DIRS is nothing more than a shortcut for

if CONFIG['ENABLE_TESTS']:
    DIRS += [...]

As such, we might as well remove it being a separate variable, and use some
Context magic to just fill DIRS when ENABLE_TESTS is set.

The security/manager/ssl/tests/unit/moz.build change ensures that the order
of DIRS before the change is kept, not because it matters, but because it
allows to confirm that nothing else is modified by this change.

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8701635 [details] [diff] [review]
Make TEST_DIRS a SPECIAL_VARIABLE

Review of attachment 8701635 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/frontend/context.py
@@ +1995,5 @@
>          ``TESTING_JS_MODULES.foo += ['module.jsm']``.
>          """),
>  
> +    'TEST_DIRS': (lambda context: context['DIRS'] if context.config.substs.get('ENABLE_TESTS')
> +                                  else TestDirsPlaceHolder, list,

Nice hack.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1bcc9c336586

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1bcc9c336586