1235020 - [gui] final result log output worthless

Status: NEW

(Testing :: mozregression, defect)

Description

[YF (Yang)]

Attachment: screenshot

I got these final log for bug 1234849:
2015-12-24T16:44:33: INFO : Narrowed inbound regression window from [22360424, 4922c784] (3 revisions) to [22360424, 8084077b] (2 revisions) (~1 steps left)
2015-12-24T16:44:33: DEBUG : Starting merge handling...
2015-12-24T16:44:33: DEBUG : Using url: https://hg.mozilla.org/integration/mozilla-inbound/json-pushes?changeset=8084077bd124bc25f521fd31fe51a9d1c508c68a&full=1
2015-12-24T16:44:34: DEBUG : Found commit message:
Bug 1217039 - Created a function android_ndk_url() in android.py and used it in all other sub-modules to calculate the URL. r=mshal


The log message is not correct attribution. The desired actual range is the "pushlog_url: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=22360424ed1532c73c93aab85bfd9173899956f8&tochange=8084077bd124bc25f521fd31fe51a9d1c508c68a" on Bisection information pane. And, I don't understand the "Using url", it is a machine-friendly format, rather than humans.

Comment 1

[Julien Pagès (:parkouss)]

Hm, in the GUI, the intended work flow is to select the last step in the bisection step, and look at the bisection information panel to see the final pushlog url.

The log contains the information, but also some debug statements. We may hide by default the debug statements at some point (maybe starting with bug 1173984). But the log view is not intended to be something required to have a result.

Does that make sense to you ? Maybe we can document that somewhere, or make things better if you have some ideas.

Comment 2

[YF (Yang)]

Well. Maybe the "Using url" should clearly indicate its audience, and indicates that the user should focus on this pushlog_url, output it to convenient copy may be better.

Also, the progress items highlight does not seem obvious, it should have a border or a different background color, not just bold.

And, I don't understand the intention of "Found commit message:", maybe it should be "Found first commit message:"?

Comment 3

[Julien Pagès (:parkouss)]

Well, as you can see this output is prefixed with DEBUG. This is because it is some debug output, so mainly useful for developers I would say - we should definitely hide this by default - but I don't want to do that before we fix bug 1173984. I will try to make some move on this side.

> Also, the progress items highlight does not seem obvious, it should have a
> border or a different background color, not just bold.

Yeah, that sounds great, highlighting more the pushlog url.

> And, I don't understand the intention of "Found commit message:", maybe it
> should be "Found first commit message:"?

So, basically mozregression tries to detect if we have a merge commit (to bisect further on the other branch). This is the message for it - but again, it is a DEBUG only thing;

So in this bug, I propose that we:

- highlight more the pushlog url result
- use a default log level of INFO (not DEBUG) - but this require that we fix bug 1173984