1235023 - Relax no-multi-spaces Eslint rule with ObjectExpression

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Marco Bonardo [:mak]]

An example:

var containers = [
  { label: "Today",       offset: 0,  visible: true },
  { label: "Yesterday",   offset: -1, visible: true },
  { label: "Last 7 days", offset: -3, visible: true },
];

Comment 1

[:Gijs (he/him)]

Hm, I would still prefer no spaces between the braces and the leading label and trailing value.

Can we special-case the alignment case in any way?

Comment 2

[Marco Bonardo [:mak]]

(In reply to :Gijs Kruitbosch from comment #1)
> Hm, I would still prefer no spaces between the braces and the leading label
> and trailing value.

this doesn't control that spacing, that is optional afaik.
This only controls the spacing after the comma.

Comment 3

[Marco Bonardo [:mak]]

(that is, this only allows/disallows multi-spaces, usually they are not allowed, so I'm adding exceptions to allow multi spaces when we usually use them to align)

Comment 4

[Marco Bonardo [:mak]]

Attachment: MozReview Request: Bug 1235023 - Relax no-multi-spaces Eslint rule with ObjectExpression.r=Mossop

Review commit: https://reviewboard.mozilla.org/r/29221/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29221/

Comment 5

[:Gijs (he/him)]

Comment on attachment 8702911 [details]
MozReview Request: Bug 1235023 - Relax no-multi-spaces Eslint rule with ObjectExpression.r=Mossop

https://reviewboard.mozilla.org/r/29221/#review26015

rs=me

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/96561dda4aef

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/96561dda4aef