1235124 - [Presentation WebAPI] Start multi-screen by Presentation API

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Chih-Hsuan Kuo [:tommykuo]]

We'll integrate multi-screen into Presentation API as the 1-UA (user-agent) use case. And it'll be the only way to start multi-screen mode currently.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] KuoE0:multi-screen > mozilla-b2g:master

Comment 2

[Chih-Hsuan Kuo [:tommykuo]]

Comment on attachment 8701975 [details] [review]
[gaia] KuoE0:multi-screen > mozilla-b2g:master

Hi Luke, can you give me some feedback on this patch? I thinks we don't need the preference to enable multi-screen now. So, I remove the code of it.

Comment 3

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8701975 [details] [review]
[gaia] KuoE0:multi-screen > mozilla-b2g:master

Basically looks good to me except a few comments only. Please take a look on GitHub. Thanks.

Comment 4

[Chih-Hsuan Kuo [:tommykuo]]

Comment on attachment 8701975 [details] [review]
[gaia] KuoE0:multi-screen > mozilla-b2g:master

Hi Luke, can you review the PR again?

Comment 5

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8701975 [details] [review]
[gaia] KuoE0:multi-screen > mozilla-b2g:master

Hi Tommy,

Since you're going to improve your patch a bit, I'd like to cancel my review request first. Please set it back when you finish. Thanks.

Comment 6

[Chih-Hsuan Kuo [:tommykuo]]

Hi Luke, I already update my patch. Can you review it again?

Comment 7

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8701975 [details] [review]
[gaia] KuoE0:multi-screen > mozilla-b2g:master

Looks good except one comment left on GitHub. Please help to address that. Thanks.

Comment 8

[Luke Chang [:lchang] (inactive)]

landed on master: https://github.com/mozilla-b2g/gaia/commit/84ac7c8812016e03f794916170b1b82976930ac7