[Presentation WebAPI] Start multi-screen by Presentation API

RESOLVED FIXED

Status

defect
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: kuoe0.tw, Assigned: kuoe0.tw)

Tracking

(Blocks 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

4 years ago
We'll integrate multi-screen into Presentation API as the 1-UA (user-agent) use case. And it'll be the only way to start multi-screen mode currently.
Assignee

Comment 2

4 years ago
Comment on attachment 8701975 [details] [review]
[gaia] KuoE0:multi-screen > mozilla-b2g:master

Hi Luke, can you give me some feedback on this patch? I thinks we don't need the preference to enable multi-screen now. So, I remove the code of it.
Attachment #8701975 - Flags: feedback?(lchang)
Assignee

Updated

4 years ago
Assignee: nobody → kuoe0
Comment on attachment 8701975 [details] [review]
[gaia] KuoE0:multi-screen > mozilla-b2g:master

Basically looks good to me except a few comments only. Please take a look on GitHub. Thanks.
Attachment #8701975 - Flags: feedback?(lchang) → feedback+
Assignee

Updated

3 years ago
Depends on: 1208417
Assignee

Comment 4

3 years ago
Comment on attachment 8701975 [details] [review]
[gaia] KuoE0:multi-screen > mozilla-b2g:master

Hi Luke, can you review the PR again?
Attachment #8701975 - Flags: review?(lchang)
Comment on attachment 8701975 [details] [review]
[gaia] KuoE0:multi-screen > mozilla-b2g:master

Hi Tommy,

Since you're going to improve your patch a bit, I'd like to cancel my review request first. Please set it back when you finish. Thanks.
Attachment #8701975 - Flags: review?(lchang)
Assignee

Comment 6

3 years ago
Hi Luke, I already update my patch. Can you review it again?
Assignee

Updated

3 years ago
Attachment #8701975 - Flags: review?(lchang)
Comment on attachment 8701975 [details] [review]
[gaia] KuoE0:multi-screen > mozilla-b2g:master

Looks good except one comment left on GitHub. Please help to address that. Thanks.
Attachment #8701975 - Flags: review?(lchang) → review+
Assignee

Updated

3 years ago
Keywords: checkin-needed
landed on master: https://github.com/mozilla-b2g/gaia/commit/84ac7c8812016e03f794916170b1b82976930ac7
Status: NEW → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.