[TV][2.5] Hide price text in preview area

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jyeh, Assigned: jyeh)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(feature-b2g:2.5+)

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
When install apps with option key in marketplace, those apps cannot be found in the result of navigator.mozApps.getInstalled.

Install apps in preview window works as expected.
(Assignee)

Updated

3 years ago
Blocks: 1204762
(Assignee)

Updated

3 years ago
Flags: needinfo?(rchien)
Because navigator.mozApps.getInstalled() return apps according install origin and trigger "add app to apps" from option key in marketplace that will try to install app from system so invoking navigator.mozApps.getInstalled() from marketplace app will not return that installed app.

we can workaround it by installing app while pressing option key as in preview window does.

Luke, do you have a better idea?
Flags: needinfo?(rchien) → needinfo?(lchang)
As our offline discussion, I don't think installing apps every time is a good solution since there may be  performance issues. Another question is: do we really need to show the "installed" status of Apps (since we can't get the same status from Websites)?

For launching behavior, I would suggest that marketplace can install it itself in the handler of "contextmenu" event and system app needs to pause the preview mechanism when a install request follows a specific "contextmenu". However, I don't think it's a better solution though.
Flags: needinfo?(lchang)
Agree. I'm going to take over it and patch will be submitted soon.
Assignee: nobody → rchien
Status: NEW → ASSIGNED

Comment 4

3 years ago
Let's try to fix bug 1218289 and avoid hack from Gaia. Joseph, please use this bug do your part modification like comment 2 suggested. Thanks.
Assignee: rchien → jyeh
(Assignee)

Updated

3 years ago
Summary: [TV][2.5] navigator.mozApps.getInstalled cannot get the apps installed by option key in marketplace → [TV][2.5] Hide price text in preview area
(Assignee)

Comment 5

3 years ago
According to comment 2, we cannot get the install status of websites. Therefore, we decide to hide the price text for now as we are closed to the project deadline.
(Assignee)

Comment 6

3 years ago
Created attachment 8703931 [details] [review]
jostw:josyeh/Marketplace/master/Bug1235135 > mozilla-b2g:master

Hi Davor, this patch will hide the price text in the preview area. You can see more discussion on this bug.

Please let me know if you have any questions, thanks!
Attachment #8703931 - Flags: review?(dspasovski)

Updated

3 years ago
feature-b2g: --- → 2.5+
Whiteboard: [ft:conndevices]
Attachment #8703931 - Flags: review?(dspasovski) → review+
(Assignee)

Comment 7

3 years ago
Landed in marketplace-tv-front-end master.

https://github.com/mozilla-b2g/marketplace-tv-front-end/commit/bd2396098d46a5178bda25e0be9b0617a8a04bf2
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
QA Whiteboard: [COM=TV::Web Apps]
You need to log in before you can comment on or make changes to this bug.